Skip to content

Commit a0bf53a

Browse files
🐛 efs - deletion of data run in executor (ITISFoundation#7013)
1 parent aca56c2 commit a0bf53a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

services/efs-guardian/src/simcore_service_efs_guardian/services/efs_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import logging
22
import os
3-
import shutil
43
from dataclasses import dataclass
54
from pathlib import Path
65

76
from fastapi import FastAPI
87
from models_library.projects import ProjectID
98
from models_library.projects_nodes_io import NodeID
109
from pydantic import ByteSize, TypeAdapter, ValidationError
10+
from servicelib.file_utils import remove_directory
1111

1212
from ..core.settings import ApplicationSettings, get_application_settings
1313
from . import efs_manager_utils
@@ -153,7 +153,7 @@ async def remove_project_efs_data(self, project_id: ProjectID) -> None:
153153
if Path.exists(_dir_path):
154154
# Remove the directory and all its contents
155155
try:
156-
shutil.rmtree(_dir_path)
156+
await remove_directory(_dir_path)
157157
_logger.info("%s has been deleted.", _dir_path)
158158
except FileNotFoundError:
159159
_logger.exception("Directory %s does not exist.", _dir_path)

tests/e2e-playwright/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ def log_in_and_out(
417417
def _open_with_resources(page: Page, *, click_it: bool):
418418
study_title_field = page.get_by_test_id("studyTitleField")
419419
# wait until the title is automatically filled up
420-
expect(study_title_field).not_to_have_value("")
420+
expect(study_title_field).not_to_have_value("", timeout=30000)
421421

422422
open_with_resources_button = page.get_by_test_id("openWithResources")
423423
if click_it:

0 commit comments

Comments
 (0)