Skip to content

Commit afce906

Browse files
pcrespovmrnicegyu11
authored andcommitted
✅ e2e: Fixes typo in tests (ITISFoundation#6468)
1 parent 7dab0e1 commit afce906

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ def __call__(self, message: str) -> bool:
226226

227227
self.logger.info(
228228
"Current startup progress [expected number of node-progress-types=%d]: %s",
229-
NodeProgressType.required_types_for_started_service(),
229+
len(NodeProgressType.required_types_for_started_service()),
230230
f"{json.dumps({k:round(v,1) for k,v in self._current_progress.items()})}",
231231
)
232232

tests/e2e-playwright/tests/conftest.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def _construct_graylog_url(
144144
scheme, tail = product_url.split("://", 1)
145145
else:
146146
scheme, tail = "https", "<UNDEFINED>"
147-
monitoring_url = f"{scheme}://monitoring.{tail}"
147+
monitoring_url = f"{scheme}://monitoring.{tail}".rstrip("/")
148148

149149
# build graylog URL
150150
query = f"from={start_time.strftime(_FORMAT)}&to={end_time.strftime(_FORMAT)}"
@@ -161,11 +161,13 @@ def pytest_runtest_makereport(item: pytest.Item, call):
161161
test_name = item.name
162162
test_location = item.location
163163
product_url = f"{item.config.getoption('--product-url', default=None)}"
164+
is_billable = item.config.getoption("--product-billable", default=None)
164165

165166
diagnostics = {
166167
"test_name": test_name,
167168
"test_location": test_location,
168169
"product_url": product_url,
170+
"is_billable": is_billable,
169171
}
170172

171173
# Get the start and end times of the test
@@ -182,7 +184,7 @@ def pytest_runtest_makereport(item: pytest.Item, call):
182184
logging.WARNING,
183185
f"ℹ️ Diagnostics report for {test_name} ---", # noqa: RUF001
184186
) as ctx:
185-
ctx.logger.warning(json.dumps(diagnostics, indent=2))
187+
ctx.logger.warning("\n%s", json.dumps(diagnostics, indent=2))
186188

187189

188190
@pytest.hookimpl(tryfirst=True)

0 commit comments

Comments
 (0)