Merge pull request #17 from danyc/master

Bug fixes

Author: Marc Rooding

README.md

@@ -4,6 +4,8 @@
 
 This is a stand-alone fork of [grunt-protractor-cucumber-html-report](https://github.com/robhil/grunt-protractor-cucumber-html-report)
 
+![Sample report](https://cloud.githubusercontent.com/assets/3902324/16930002/00f575c6-4d43-11e6-85fd-bcfeea694007.png "Sample report")
+
 ## Getting Started
 This plugin requires Gulp `~3.9.0`
 

lib/html_formatter.js

@@ -38,6 +38,15 @@ module.exports = (function () {
     return step.keyword.trim() === 'After' && step.name === undefined && step.embeddings === undefined;
   }
 
+  /**
+   * Checks if the step is an empty Before step
+   * @param step - object which contains step data
+   * @returns boolean
+   */
+  function isEmptyBeforeStep(step) {
+    return step.keyword.trim() === 'Before' && step.name === undefined && step.embeddings === undefined;
+  }
+
   /**
    * Checks if the step is an After step containing a screenshot
    * @param step - object which contains step data
@@ -62,7 +71,7 @@ module.exports = (function () {
     return compiled({
       status: step.result ? step.result.status : '',
       errorDetails: step.result ? toHtmlEntities(step.result.error_message) : '',
-      name: step.keyword + step.name,
+      name: step.keyword + (step.name ? step.name : ''),
       dataTable: step.rows ? step.rows : ''
     });
   }
@@ -178,7 +187,7 @@ module.exports = (function () {
             for (var k = 0; k < testResults[i].elements[j].steps.length; k++) {
               step = testResults[i].elements[j].steps[k];
 
-              if(isEmptyAfterStep(step)) {
+              if(isEmptyAfterStep(step) || isEmptyBeforeStep(step)) {
                 continue;
               }
 

test/data/cucumber_report.json

@@ -16,6 +16,17 @@
         "description": "",
         "type": "scenario",
         "steps": [
+          {
+            "keyword": "Before ",
+            "hidden": true,
+            "result": {
+              "status": "passed",
+              "duration": 11258903
+            },
+            "match": {
+              "location": "...\\src\\test\\hooks.js:2"
+            }
+          },
           {
             "name": "I login as teacher",
             "line": 4,