Clean up the html formatter

Author: Marc Rooding

lib/html_formatter.js

@@ -15,7 +15,6 @@ module.exports = (function () {
     PENDING: 'pending',
     SKIPPED: 'skipped'
   },
-  html = '',
   templates;
 
   /**
@@ -54,7 +53,6 @@ module.exports = (function () {
     return compiled({
       status: step.result ? step.result.status : '',
       errorDetails: step.result ? toHtmlEntities(step.result.error_message) : '',
-      screenshot: step.embeddings && step.embeddings[0] ? step.embeddings[0].data : '',
       name: step.keyword + step.name
     });
   }
@@ -144,30 +142,24 @@ module.exports = (function () {
    */
   function generateHTML(testResults) {
     var stepsHtml = '',
-    header = '',
     isPassed = false,
     passedScenarios = 0,
     passedSteps = 0,
     stepsNumber = 0,
     scenariosNumber = 0,
-    scenariosNumberInFeature = 0,
-    passedScenariosNumberInFeature = 0,
-    stepsNumberInFeature = 0,
-    passedStepsInFeature = 0,
-    element,
     html = '',
     step;
 
     for (var i = 0; i < testResults.length; i++) {
-      scenariosHtml = '';
-      scenariosNumberInFeature = 0;
-      passedScenariosNumberInFeature = 0;
-      stepsNumberInFeature = 0;
+      var scenariosHtml = '',
+      scenariosNumberInFeature = 0,
+      passedScenariosNumberInFeature = 0,
+      stepsNumberInFeature = 0,
       passedStepsInFeature = 0;
 
       if (testResults[i].elements) {
         for (var j = 0; j < testResults[i].elements.length; j++) {
-          element = testResults[i].elements[j];
+          var element = testResults[i].elements[j];
           if (element.type === 'scenario') {
             scenariosNumber++;
             scenariosNumberInFeature++;
@@ -176,7 +168,7 @@ module.exports = (function () {
             for (var k = 0; k < testResults[i].elements[j].steps.length; k++) {
               step = testResults[i].elements[j].steps[k];
 
-              if(isAfterStepWithScreenshot(step)) {
+              if (isAfterStepWithScreenshot(step)) {
                 stepsHtml += getAfterScreenshotStep(step);
               } else {
                 stepsHtml += getStep(step);