Skip to content

Commit 39e15bd

Browse files
authored
perf: Make Kotlin View Managers final (#1181)
1 parent ea5d348 commit 39e15bd

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

packages/nitrogen/src/views/kotlin/KotlinHybridViewManager.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ import ${javaNamespace}.*
5353
/**
5454
* Represents the React Native \`ViewManager\` for the "${spec.name}" Nitro HybridView.
5555
*/
56-
open class ${manager}: SimpleViewManager<View>() {
56+
public class ${manager}: SimpleViewManager<View>() {
5757
init {
5858
if (RecyclableView::class.java.isAssignableFrom(${viewImplementation}::class.java)) {
5959
// Enable view recycling
@@ -152,7 +152,7 @@ namespace ${cxxNamespace} {
152152
153153
using namespace facebook;
154154
155-
class J${stateUpdaterName}: public jni::JavaClass<J${stateUpdaterName}> {
155+
class J${stateUpdaterName} final: public jni::JavaClass<J${stateUpdaterName}> {
156156
public:
157157
static constexpr auto kJavaDescriptor = "L${updaterJniDescriptor};";
158158

packages/react-native-nitro-test/nitrogen/generated/android/c++/views/JHybridRecyclableTestViewStateUpdater.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace margelo::nitro::test::views {
2424

2525
using namespace facebook;
2626

27-
class JHybridRecyclableTestViewStateUpdater: public jni::JavaClass<JHybridRecyclableTestViewStateUpdater> {
27+
class JHybridRecyclableTestViewStateUpdater final: public jni::JavaClass<JHybridRecyclableTestViewStateUpdater> {
2828
public:
2929
static constexpr auto kJavaDescriptor = "Lcom/margelo/nitro/test/views/HybridRecyclableTestViewStateUpdater;";
3030

packages/react-native-nitro-test/nitrogen/generated/android/c++/views/JHybridTestViewStateUpdater.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace margelo::nitro::test::views {
2424

2525
using namespace facebook;
2626

27-
class JHybridTestViewStateUpdater: public jni::JavaClass<JHybridTestViewStateUpdater> {
27+
class JHybridTestViewStateUpdater final: public jni::JavaClass<JHybridTestViewStateUpdater> {
2828
public:
2929
static constexpr auto kJavaDescriptor = "Lcom/margelo/nitro/test/views/HybridTestViewStateUpdater;";
3030

packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridRecyclableTestViewManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import com.margelo.nitro.test.*
1919
/**
2020
* Represents the React Native `ViewManager` for the "RecyclableTestView" Nitro HybridView.
2121
*/
22-
open class HybridRecyclableTestViewManager: SimpleViewManager<View>() {
22+
public class HybridRecyclableTestViewManager: SimpleViewManager<View>() {
2323
init {
2424
if (RecyclableView::class.java.isAssignableFrom(HybridRecyclableTestView::class.java)) {
2525
// Enable view recycling

packages/react-native-nitro-test/nitrogen/generated/android/kotlin/com/margelo/nitro/test/views/HybridTestViewManager.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import com.margelo.nitro.test.*
1919
/**
2020
* Represents the React Native `ViewManager` for the "TestView" Nitro HybridView.
2121
*/
22-
open class HybridTestViewManager: SimpleViewManager<View>() {
22+
public class HybridTestViewManager: SimpleViewManager<View>() {
2323
init {
2424
if (RecyclableView::class.java.isAssignableFrom(HybridTestView::class.java)) {
2525
// Enable view recycling

0 commit comments

Comments
 (0)