fix: Reconstruct enum types from flattened string literal unions in variantsFix/boolean string enum variant #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariants TypeScript flattens `boolean | SomeEnum` into `boolean | 'foo' | 'bar'`, losing the enum type information. This fix reconstructs the original enum types by searching all type aliases in the project and matching their string literal values against the flattened union. - Add `initializeTypeCreation()` to build a cache of type aliases for lookup - Add `reconstructEnumTypesFromStringLiterals()` to find matching enum types - Handle variants with multiple string enums (e.g., `SomeEnum | SomeOtherEnum`) - Detect and throw error for overlapping enums (ambiguous discrimination) - Add test cases for various enum+primitive combinations
|
Someone is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Hey - thank you so much for this PR, this is pretty cool. I would say this is a very convenient feature, but I am a bit hesitant on merging it due to the amount of code it requires, and stuff like the "hacky" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TypeScript flattens
boolean | SomeEnumintoboolean | 'foo' | 'bar', the named enum type information is lost. This PR reconstructs the original enum types by searching all type aliases in the project and matching their string literal values.Changes
initializeTypeCreation()to build a cache of type aliases for efficient lookupreconstructEnumTypesFromStringLiterals()to find matching enum types from flattened unionsTestObject.nitro.ts