Skip to content

Commit d22a8f0

Browse files
committed
Added additional test for the Department method.
1 parent 976309a commit d22a8f0

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/FakerDotNet/Fakers/CommerceFaker.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,10 @@ public string Color()
3232
public string Department(int max = 3, bool fixedAmount = false)
3333
{
3434
var num = fixedAmount ? max : Convert.ToInt32(_fakerContainer.Number.Between(1, max));
35-
36-
if (num <= 1) return _fakerContainer.Random.Element(CommerceData.Departments);
37-
3835
var departments = _fakerContainer.Random.Assortment(CommerceData.Departments, num).ToArray();
3936

37+
if (num == 1) return departments[0];
38+
4039
return string.Join(" & ",
4140
string.Join(", ", departments.Take(departments.Length - 1)),
4241
departments.Last());

tests/FakerDotNet.Tests/Fakers/CommerceFakerTests.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,15 @@ public void Department_returns_a_department_with_a_fixed_number_of_categories()
5959
Assert.AreEqual("Books & Tools", _commerceFaker.Department(2, true));
6060
}
6161

62+
[Test]
63+
public void Department_returns_single_department_if_only_one_department_requested()
64+
{
65+
A.CallTo(() => _fakerContainer.Random.Assortment(CommerceData.Departments, 1))
66+
.Returns(new[] {"Health"});
67+
68+
Assert.AreEqual("Health", _commerceFaker.Department(1, true));
69+
}
70+
6271
[Test]
6372
public void Material_returns_a_material()
6473
{

0 commit comments

Comments
 (0)