Save curlCode and curlError to lastRequest

redirectCount is supposed to be a long--this was probably causing memory
corruption

Author: Spencatro

include/restclient-cpp/connection.h

@@ -56,6 +56,12 @@ class Connection {
       *  @var RequestInfo::redirectCount
       *  Member 'redirectCount' contains the number of redirects followed. See
       *  CURLINFO_REDIRECT_COUNT
+      *  @var RequestInfo::curlCode
+      *  Member 'curlCode' contains the cURL code (cast to int). See
+      *  libcurl-errors
+      *  @var RequestInfo::curlError
+      *  Member 'curlError' contains the cURL error as a string, if any. See
+      *  CURLOPT_ERRORBUFFER
       */
     typedef struct {
         double totalTime;
@@ -65,7 +71,9 @@ class Connection {
         double preTransferTime;
         double startTransferTime;
         double redirectTime;
-        int redirectCount;
+        long redirectCount;
+        int curlCode;
+        std::string curlError;
       } RequestInfo;
     /**
       *  @struct Info
@@ -231,6 +239,7 @@ class Connection {
     std::string keyPassword;
     std::string uriProxy;
     std::string unixSocketPath;
+    char curlErrorBuf[CURL_ERROR_SIZE];
     RestClient::Response performCurlRequest(const std::string& uri);
 };
 };  // namespace RestClient

source/connection.cc

@@ -359,6 +359,10 @@ RestClient::Connection::performCurlRequest(const std::string& uri) {
     curl_easy_setopt(this->curlHandle, CURLOPT_HTTPAUTH, CURLAUTH_BASIC);
     curl_easy_setopt(this->curlHandle, CURLOPT_USERPWD, authString.c_str());
   }
+  /** set error buffer */
+  curl_easy_setopt(this->curlHandle, CURLOPT_ERRORBUFFER,
+                   this->curlErrorBuf);
+  
   /** set user agent */
   curl_easy_setopt(this->curlHandle, CURLOPT_USERAGENT,
                    this->GetUserAgent().c_str());
@@ -441,6 +445,7 @@ RestClient::Connection::performCurlRequest(const std::string& uri) {
   }
 
   res = curl_easy_perform(this->curlHandle);
+  this->lastRequest.curlCode = res;
   if (res != CURLE_OK) {
     switch (res) {
       case CURLE_OPERATION_TIMEDOUT:
@@ -461,6 +466,8 @@ RestClient::Connection::performCurlRequest(const std::string& uri) {
     ret.code = static_cast<int>(http_code);
   }
 
+  this->lastRequest.curlError = std::string(this->curlErrorBuf);
+
   curl_easy_getinfo(this->curlHandle, CURLINFO_TOTAL_TIME,
                     &this->lastRequest.totalTime);
   curl_easy_getinfo(this->curlHandle, CURLINFO_NAMELOOKUP_TIME,