Add build type filter combo box to toolbar

ToolbarPopUpButtonItem class added to VS Mac so it is now
possible to show a combo box in the pad toolbar with the build
types. This is used to filter the list items.

Author: mrward

src/MonoDevelop.ProjectSystem.Tools/MonoDevelop.ProjectSystem.Tools.Gui/BuildLoggingPad.cs

@@ -42,7 +42,8 @@ public class BuildLoggingPad : PadContent
 		ToolbarButtonItem startButton;
 		ToolbarButtonItem stopButton;
 		ToolbarButtonItem clearButton;
-		ComboBox buildTypeFilterComboBox;
+		ToolbarPopUpButtonItem buildTypeFilterComboBox;
+		ContextMenu buildTypeFilterMenu;
 		ToolbarSearchItem searchEntry;
 		TimeSpan searchDelayTimeSpan = TimeSpan.FromMilliseconds (250);
 		IDisposable searchTimer;
@@ -72,9 +73,12 @@ public override void Dispose ()
 			startButton.Clicked -= OnStartButtonClicked;
 			stopButton.Clicked -= OnStopButtonClicked;
 			clearButton.Clicked -= OnClearButtonClicked;
-			buildTypeFilterComboBox.Changed -= BuildTypeFilterComboBoxChanged;
 			searchEntry.TextChanged -= SearchEntryChanged;
 
+			foreach (ContextMenuItem menuItem in buildTypeFilterMenu.Items) {
+				menuItem.Clicked -= BuildTypeFilterComboBoxChanged;
+			}
+
 			DisposeExistingTimer ();
 
 			widget.Dispose ();
@@ -106,13 +110,9 @@ protected override void Initialize (IPadWindow window)
 			clearButton.Tooltip = GettextCatalog.GetString ("Clear");
 			toolbar.AddItem (clearButton);
 
-			//string[] buildTypeItems = buildTypes
-			//	.Select (buildType => GetDisplayText (buildType))
-			//	.ToArray ();
-			//buildTypeFilterComboBox = new ComboBox (buildTypeItems);
-			//buildTypeFilterComboBox.Active = 0;
-			//buildTypeFilterComboBox.Changed += BuildTypeFilterComboBoxChanged;
-			//toolbar.Add (buildTypeFilterComboBox);
+			buildTypeFilterComboBox = new ToolbarPopUpButtonItem (toolbar.Properties, nameof (buildTypeFilterComboBox));
+			buildTypeFilterComboBox.MenuCreator = () => CreateBuildTypeFilterMenu ();
+			toolbar.AddItem (buildTypeFilterComboBox);
 
 			searchEntry = new ToolbarSearchItem (toolbar.Properties, nameof (searchEntry));
 			searchEntry.Position = ToolbarItemPosition.Trailing;
@@ -130,6 +130,26 @@ protected override void Initialize (IPadWindow window)
 			ProjectSystemService.MSBuildTargetFinished += MSBuildTargetFinished;
 		}
 
+		ContextMenu CreateBuildTypeFilterMenu ()
+		{
+			string[] buildTypeItems = buildTypes
+				.Select (buildType => GetDisplayText (buildType))
+				.ToArray ();
+
+			buildTypeFilterMenu = new ContextMenu ();
+
+			foreach (BuildType buildType in buildTypes) {
+				var menuItem = new ContextMenuItem ();
+				menuItem.Label = GetDisplayText (buildType);
+				menuItem.Context = buildType;
+				menuItem.Clicked += BuildTypeFilterComboBoxChanged;
+
+				buildTypeFilterMenu.Items.Add (menuItem);
+			}
+
+			return buildTypeFilterMenu;
+		}
+
 		void OnStartButtonClicked (object sender, EventArgs e)
 		{
 			ProjectSystemService.IsEnabled = true;
@@ -177,9 +197,9 @@ static string GetDisplayText (BuildType buildType)
 			}
 		}
 
-		void BuildTypeFilterComboBoxChanged (object sender, EventArgs e)
+		void BuildTypeFilterComboBoxChanged (object sender, ContextMenuItemClickedEventArgs e)
 		{
-			widget.BuildType = buildTypes [buildTypeFilterComboBox.Active];
+			widget.BuildType = (BuildType)e.Context;
 		}
 
 		void SearchEntryChanged (object sender, EventArgs e)