keyParser: fix equals()

Author: mscdex

lib/protocol/keyParser.js

@@ -446,7 +446,7 @@ const BaseKey = {
       this.type === parsed.type
       && this[SYM_PRIV_PEM] === parsed[SYM_PRIV_PEM]
       && this[SYM_PUB_PEM] === parsed[SYM_PUB_PEM]
-      && this[SYM_PUB_SSH] === parsed[SYM_PUB_SSH]
+      && this[SYM_PUB_SSH].equals(parsed[SYM_PUB_SSH])
     );
   },
 };

test/test-protocol-keyparser.js

@@ -82,6 +82,22 @@ readdirSync(BASE_PATH).forEach((name) => {
                   + `Received: ${inspect(details)}`)
       );
     });
+
+    // Test `equals()`
+    let copy;
+    if (isEncrypted)
+      copy = parseKey(key, (isPPK ? 'node.js' : 'password'));
+    else
+      copy = parseKey(key);
+    if (!Array.isArray(copy))
+      copy = [copy];
+    for (let i = 0; i < res.length; ++i) {
+      assert.strictEqual(
+        res[i].equals(copy[i]),
+        true,
+        failMsg(name, 'equals() failed with copy')
+      );
+    }
   }
 
   if (isEncrypted && !isPublic) {