Skip to content

[BUG] False positives on extension scanning #50

@calien666

Description

@calien666

First of all, thank you for this great tool.

I'm currently Upgrading a version 11 to 13 and used the extension scanner on the existing v11 with target 11.

During the review of the scanned result, I detected lots of false positives regarding the Breaking: #93023 - Reworked session handling.

We use modern PHP in the project (PHP 8.1) with public readonly properties on Domain Transfer Objects and Models, which are calling properties directly instead of a getter. This causes the extension scanner to report issues on these calls.

Example code:

<?php

class Dto
{
    __construct(public readonly int $id) {}
}
<?php

class WorkWithDto
{
    public function doSomething(Dto $object)
    {
        $theId = $object->id;
    }
}

As the breaking is correct for the respective class, the above example code will trigger the scanner every time, this is used. In our case, it led to about 60 false positives.

Is there a way to suppress these things or a possibility checking, if the respective class of the breaking change is used?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions