Move merge_entries_non_interactive to bibdedup CLI

Co-authored-by: mseri <[email protected]>

Author: Copilot

CHANGES.md

@@ -3,10 +3,10 @@
 - bibfmt: added --quiet flag to suppress all output except errors.
 - bibfmt: added --force flag to ignore parsing errors and output only
   successfully parsed entries.
-- bibfmt: refactored deduplication functions - moved IO-dependent functions
-  (deduplicate_entries, resolve_conflicts) from library to bibdedup CLI tool.
-  The library now provides only pure functions (find_duplicate_groups,
-  merge_entries_non_interactive) for programmatic use.
+- bibfmt: refactored deduplication functions - moved all deduplication logic
+  (deduplicate_entries, resolve_conflicts, merge_entries_non_interactive) from
+  library to bibdedup CLI tool. The library now provides only the core
+  find_duplicate_groups function for programmatic use.
 
 # 0.7.8 (2025-10-09)
 

bibfmt/bin/bibdedup.ml

@@ -100,6 +100,37 @@ let resolve_conflicts duplicate_group =
 
   { base_entry with Bibtex.contents = merged_contents }
 
+(* Merge entries non-interactively by keeping first occurrence of each field *)
+let merge_entries_non_interactive entries =
+  if entries = [] then invalid_arg "merge_entries_non_interactive: empty list"
+  else
+    let base_entry = List.hd entries in
+    let merged_fields = Hashtbl.create 16 in
+
+    (* Collect all fields, keeping first occurrence *)
+    List.iter
+      (fun entry ->
+        List.iter
+          (function
+            | Bibtex.Field { name; value } ->
+                let name_lower = String.lowercase_ascii name in
+                if not (Hashtbl.mem merged_fields name_lower) then
+                  Hashtbl.replace merged_fields name_lower
+                    (name, Bibtex.string_of_field_value value)
+            | Bibtex.EntryComment _ -> ())
+          entry.Bibtex.contents)
+      entries;
+
+    (* Build merged entry *)
+    let merged_contents =
+      Hashtbl.fold
+        (fun _ (name, value) acc -> Bibtex.make_field name value :: acc)
+        merged_fields []
+      |> List.rev
+    in
+
+    { base_entry with Bibtex.contents = merged_contents }
+
 (* Main deduplication function with IO *)
 let deduplicate_entries ?(keys = [ "title"; "author"; "year" ])
     ?(interactive = true) entries =
@@ -128,7 +159,7 @@ let deduplicate_entries ?(keys = [ "title"; "author"; "year" ])
       List.map
         (fun group ->
           if interactive then resolve_conflicts group
-          else Bibtex.merge_entries_non_interactive group.Bibtex.entries)
+          else merge_entries_non_interactive group.Bibtex.entries)
         duplicate_groups
     in
 

bibfmt/lib/bibtex.ml

@@ -861,35 +861,4 @@ let find_duplicate_groups ?(keys = [ "title"; "author"; "year" ]) entries =
       else None)
     grouped
 
-(* Merge entries non-interactively by keeping first occurrence of each field *)
-let merge_entries_non_interactive entries =
-  if entries = [] then invalid_arg "merge_entries_non_interactive: empty list"
-  else
-    let base_entry = List.hd entries in
-    let merged_fields = Hashtbl.create 16 in
-
-    (* Collect all fields, keeping first occurrence *)
-    List.iter
-      (fun entry ->
-        List.iter
-          (function
-            | Field { name; value } ->
-                let name_lower = String.lowercase_ascii name in
-                if not (Hashtbl.mem merged_fields name_lower) then
-                  Hashtbl.replace merged_fields name_lower
-                    (name, string_of_field_value value)
-            | EntryComment _ -> ())
-          entry.contents)
-      entries;
-
-    (* Build merged entry *)
-    let merged_contents =
-      Hashtbl.fold
-        (fun _ (name, value) acc -> make_field name value :: acc)
-        merged_fields []
-      |> List.rev
-    in
-
-    { base_entry with contents = merged_contents }
-
 

bibfmt/lib/bibtex.mli

@@ -190,18 +190,6 @@ val find_duplicate_groups :
     This is useful for inspecting duplicates before deciding how to handle them.
     Each group contains at least 2 entries that match on the specified keys. *)
 
-val merge_entries_non_interactive : bibtex_entry list -> bibtex_entry
-(** [merge_entries_non_interactive entries] merges duplicate entries by keeping
-    the first occurrence of each field.
-
-    @param entries List of duplicate entries to merge (must be non-empty)
-    @return Merged entry with fields from the first entry taking precedence
-    @raise Invalid_argument if the entries list is empty
-
-    This function does not prompt the user and simply takes the first value it
-    encounters for each field. It's useful for batch processing or when you
-    trust the ordering of your entries. *)
-
 val string_of_field_value : field_value -> string
 (** [string_of_field_value fv] converts a field value to its string representation.
     @param fv The field value to convert