Add dummy PortManager subclasses for SSH and ADB platforms

Change-Id: I5a6a5c286d91e175e1a99e93fcba2539777f6ef8
Reviewed-on: https://chromium-review.googlesource.com/c/crossbench/+/6652281
Reviewed-by: Patrick Thier <[email protected]>
Commit-Queue: Camillo Bruni <[email protected]>

Author: camillobruni

crossbench/plt/android_adb.py

@@ -20,6 +20,7 @@
 from crossbench.parse import NumberParser
 from crossbench.plt.arch import MachineArch
 from crossbench.plt.base import SubprocessError
+from crossbench.plt.port_manager import PortManager
 from crossbench.plt.posix import RemotePosixPlatform
 from crossbench.plt.process_meminfo import ProcessMeminfo
 
@@ -460,16 +461,26 @@ def grant_permissions(self, package_name: str) -> None:
       self.shell(*cmd)
 
 
+class AndroidAdbPortManager(PortManager):
+
+  def __init__(self, platform: AndroidAdbPlatform, adb: Adb) -> None:
+    super().__init__(platform)
+    self._adb = adb
+
+
 class AndroidAdbPlatform(RemotePosixPlatform):
 
   def __init__(self,
                host_platform: Platform,
                device_identifier: Optional[str] = None,
                adb: Optional[Adb] = None) -> None:
-    super().__init__(host_platform)
     assert not host_platform.is_remote, (
         "adb on remote platform is not supported yet")
     self._adb = adb or Adb(host_platform, device_identifier)
+    super().__init__(host_platform)
+
+  def _create_port_manager(self) -> PortManager:
+    return AndroidAdbPortManager(self, self._adb)
 
   @property
   @override

crossbench/plt/base.py

@@ -109,7 +109,10 @@ class Platform(abc.ABC):
   def __init__(self) -> None:
     self._binary_lookup_override: dict[str, pth.AnyPath] = {}
     self._cache_dir_root: pth.AnyPath | None = None
-    self._default_port_manager: PortManager = PortManager(self)
+    self._default_port_manager: PortManager = self._create_port_manager()
+
+  def _create_port_manager(self) -> PortManager:
+    return PortManager(self)
 
   def assert_is_local(self) -> None:
     if self.is_local:

crossbench/plt/linux_ssh.py

@@ -16,11 +16,12 @@
 from crossbench import parse
 from crossbench.plt.arch import MachineArch
 from crossbench.plt.linux import RemoteLinuxPlatform
-from crossbench.plt.ssh import SshPlatformMixin
+from crossbench.plt.ssh import SshPlatformMixin, SshPortManager
 
 if TYPE_CHECKING:
   from crossbench.path import AnyPath, LocalPath
   from crossbench.plt.base import CmdArg, CmdArgs, ListCmdArgs, Platform
+  from crossbench.plt.port_manager import PortManager
 
 
 class LinuxSshPlatform(SshPlatformMixin, RemoteLinuxPlatform):
@@ -38,6 +39,9 @@ def __init__(self, host_platform: Platform, host: str, port: int,
     self._reverse_port_forward_popens: dict[int, subprocess.Popen] = {}
     atexit.register(self._stop_all_port_forward)
 
+  def _create_port_manager(self) -> PortManager:
+    return SshPortManager(self)
+
   @property
   @override
   def name(self) -> str:

crossbench/plt/ssh.py

@@ -9,12 +9,16 @@
 from typing import TYPE_CHECKING, Mapping, Optional
 
 from crossbench.plt.base import Platform
+from crossbench.plt.port_manager import PortManager
 from crossbench.plt.remote import RemotePlatformMixin
 
 if TYPE_CHECKING:
   from crossbench.plt.base import CmdArg, ListCmdArgs
 
 
+class SshPortManager(PortManager):
+  pass
+
 class SshPlatformMixin(RemotePlatformMixin, metaclass=abc.ABCMeta):
 
   def __init__(self, host_platform: Platform, host: str, port: int,
@@ -25,6 +29,10 @@ def __init__(self, host_platform: Platform, host: str, port: int,
     self._ssh_port = ssh_port
     self._ssh_user = ssh_user
 
+  @abc.abstractmethod
+  def _create_port_manager(self) -> PortManager:
+    pass
+
   @property
   def host(self) -> str:
     return self._host