Skip to content

Commit 2e43a86

Browse files
kalutesV8 LUCI CQ
authored andcommitted
Consolidate dumpsys usage
Consolidate 'adb shell dumpsys' usage to the dumpsys helper function in the Adb class. Change-Id: I3b94d6762ad612be0314a2dde6d4c69be5309085 Reviewed-on: https://chromium-review.googlesource.com/c/crossbench/+/6692874 Reviewed-by: Charles Dick <[email protected]> Commit-Queue: Kameron Lutes <[email protected]>
1 parent 23cd353 commit 2e43a86

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

crossbench/plt/android_adb.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,10 @@ def dumpsys(self,
369369
cmd: ListCmdArgs = ["dumpsys", *args]
370370
return self.shell_stdout(*cmd, quiet=quiet, encoding=encoding)
371371

372+
def dumpsys_bytes(self, *args: str, quiet: bool = False) -> bytes:
373+
cmd: ListCmdArgs = ["dumpsys", *args]
374+
return self.shell_stdout_bytes(*cmd, quiet=quiet)
375+
372376
def getprop(self,
373377
*args: str,
374378
quiet: bool = False,
@@ -678,7 +682,7 @@ def check_autobrightness(self) -> bool:
678682

679683
@override
680684
def get_main_display_brightness(self) -> int:
681-
display_info: str = self.adb.shell_stdout("dumpsys", "display")
685+
display_info: str = self.adb.dumpsys("display")
682686
match_result = self._BRIGHTNESS_RE.search(display_info)
683687
if match_result is None:
684688
raise ValueError("Could not parse adb display brightness.")
@@ -762,9 +766,9 @@ def meminfo(
762766
self, process_name: str, timeout: dt.timedelta = dt.timedelta(seconds=10)
763767
) -> dict[str, ProcessMeminfo]:
764768
timeout_ms = int(timeout / dt.timedelta(milliseconds=1))
765-
dumpsys_output = self.sh_stdout_bytes("dumpsys", "-T", str(timeout_ms),
766-
"meminfo", "--proto", "--package",
767-
process_name)
769+
dumpsys_output: bytes = self.adb.dumpsys_bytes("-T", str(timeout_ms),
770+
"meminfo", "--proto",
771+
"--package", process_name)
768772
return self._parse_dumpsys_meminfo(dumpsys_output)
769773

770774
@functools.lru_cache(maxsize=1)
@@ -831,7 +835,7 @@ def display_details(self) -> tuple[DisplayInfo, ...]:
831835

832836
@override
833837
def display_resolution(self) -> tuple[int, int]:
834-
displays_out = self.sh_stdout("dumpsys", "window", "displays")
838+
displays_out = self.adb.dumpsys("window", "displays")
835839
match_result = self._DUMPSYS_WINDOW_DISPLAYS_RE.search(displays_out)
836840
if match_result is None:
837841
raise ValueError(

0 commit comments

Comments
 (0)