Remove stray const when passing std::string_view arguments.

These may be remnants from a time before string_view when a const
char* would have made sense. Now the const doesn't matter.

Fully automated change.

Change-Id: I2dfc7ce30a54701639535a4f137dc18e71575fe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5906184
Reviewed-by: Daniel Cheng <[email protected]>
Owners-Override: Daniel Cheng <[email protected]>
Commit-Queue: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1363323}


CrOS-Libchrome-Original-Commit: b55f2f1f5e65a3f2da4ded9337553c7b37169e39

Author: tsepez

base/allocator/dispatcher/tls.cc

@@ -96,7 +96,7 @@ PThreadTLSSystem& PThreadTLSSystem::operator=(PThreadTLSSystem&& other) {
 
 bool PThreadTLSSystem::Setup(
     OnThreadTerminationFunction thread_termination_function,
-    const std::string_view instance_id) {
+    std::string_view instance_id) {
 #if DCHECK_IS_ON()
   // Initialize must happen outside of the allocation path. Therefore, it is
   // secure to verify with DCHECK.

base/allocator/dispatcher/tls.h

@@ -111,7 +111,7 @@ class BASE_EXPORT PThreadTLSSystem {
   // @param thread_termination_function An optional function which will be
   // invoked upon termination of a thread.
   bool Setup(OnThreadTerminationFunction thread_termination_function,
-             const std::string_view instance_id);
+             std::string_view instance_id);
   // Tear down the TLS system. After completing tear down, the thread
   // termination function passed to Setup will not be invoked anymore.
   bool TearDownForTesting();
@@ -199,15 +199,15 @@ template <typename PayloadType,
           size_t AllocationChunkSize,
           bool IsDestructibleForTesting>
 struct ThreadLocalStorage {
-  explicit ThreadLocalStorage(const std::string_view instance_id)
+  explicit ThreadLocalStorage(std::string_view instance_id)
       : root_(AllocateAndInitializeChunk()) {
     Initialize(instance_id);
   }
 
   // Create a new instance of |ThreadLocalStorage| using the passed allocator
   // and TLS system. This initializes the underlying TLS system and creates the
   // first chunk of data.
-  ThreadLocalStorage(const std::string_view instance_id,
+  ThreadLocalStorage(std::string_view instance_id,
                      AllocatorType allocator,
                      TLSSystemType tls_system)
       : allocator_(std::move(allocator)),
@@ -360,7 +360,7 @@ struct ThreadLocalStorage {
   }
 
   // Perform common initialization during construction of an instance.
-  void Initialize(const std::string_view instance_id) {
+  void Initialize(std::string_view instance_id) {
     // The constructor must be called outside of the allocation path. Therefore,
     // it is secure to verify with CHECK.
 

base/allocator/dispatcher/tls_unittest.cc

@@ -69,7 +69,7 @@ struct TLSSystemMockBase {
       bool,
       Setup,
       (internal::OnThreadTerminationFunction thread_termination_function,
-       const std::string_view instance_id),
+       std::string_view instance_id),
       ());
   MOCK_METHOD(bool, TearDownForTesting, (), ());
   MOCK_METHOD(void*, GetThreadSpecificData, (), ());

base/hash/sha1.h

@@ -37,7 +37,7 @@ BASE_EXPORT std::string SHA1HashString(std::string_view str);
 
 // These functions allow streaming SHA-1 operations.
 BASE_EXPORT void SHA1Init(SHA1Context& context);
-BASE_EXPORT void SHA1Update(const std::string_view data, SHA1Context& context);
+BASE_EXPORT void SHA1Update(std::string_view data, SHA1Context& context);
 BASE_EXPORT void SHA1Final(SHA1Context& context, SHA1Digest& digest);
 }  // namespace base
 

base/hash/sha1_nacl.cc

@@ -168,7 +168,7 @@ void SHA1Init(SHA1Context& context) {
   context.Init();
 }
 
-void SHA1Update(const std::string_view data, SHA1Context& context) {
+void SHA1Update(std::string_view data, SHA1Context& context) {
   context.Update(data.data(), data.size());
 }
 

base/test/test_suite.cc

@@ -443,8 +443,8 @@ void TestSuite::DisableCheckForLeakedGlobals() {
 
 void TestSuite::UnitTestAssertHandler(const char* file,
                                       int line,
-                                      const std::string_view summary,
-                                      const std::string_view stack_trace) {
+                                      std::string_view summary,
+                                      std::string_view stack_trace) {
 #if BUILDFLAG(IS_ANDROID)
   // Correlating test stdio with logcat can be difficult, so we emit this
   // helpful little hint about what was running.  Only do this for Android

base/test/test_suite.h

@@ -72,8 +72,8 @@ class TestSuite {
   // terminates the process.
   void UnitTestAssertHandler(const char* file,
                              int line,
-                             const std::string_view summary,
-                             const std::string_view stack_trace);
+                             std::string_view summary,
+                             std::string_view stack_trace);
 
   // Disable crash dialogs so that it doesn't gum up the buildbot
   virtual void SuppressErrorDialogs();

components/policy/core/common/policy_logger.cc

@@ -100,7 +100,7 @@ bool IsLogExpired(PolicyLogger::Log& log) {
 PolicyLogger::Log::Log(const Severity log_severity,
                        const Source log_source,
                        const std::string& message,
-                       const std::string_view file,
+                       std::string_view file,
                        const int line)
     : log_severity_(log_severity),
       log_source_(log_source),
@@ -118,7 +118,7 @@ PolicyLogger::LogHelper::LogHelper(
     const PolicyLogger::Log::Severity log_severity,
     const int log_verbosity,
     const PolicyLogger::Log::Source log_source,
-    const std::string_view file,
+    std::string_view file,
     const int line)
     : log_type_(log_type),
       log_severity_(log_severity),

components/policy/core/common/policy_logger.h

@@ -86,7 +86,7 @@ class POLICY_EXPORT PolicyLogger {
     Log(const Severity log_severity,
         const Source log_source,
         const std::string& message,
-        const std::string_view file,
+        std::string_view file,
         const int line);
     Log(const Log&) = delete;
     Log& operator=(const Log&) = delete;
@@ -126,7 +126,7 @@ class POLICY_EXPORT PolicyLogger {
               const PolicyLogger::Log::Severity log_severity,
               const int log_verbosity,
               const PolicyLogger::Log::Source log_source,
-              const std::string_view file,
+              std::string_view file,
               const int line);
     LogHelper(const LogHelper&) = delete;
     LogHelper& operator=(const LogHelper&) = delete;