Skip to content

Commit 83244c3

Browse files
authored
Merge pull request #13 from msgflo/remove-sendtoqueue
Remove deprecated sendToQueue()
2 parents 54876ae + 542318a commit 83244c3

File tree

6 files changed

+19
-13
lines changed

6 files changed

+19
-13
lines changed

CHANGES.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
11

2+
# msgflo-nodejs 0.7.0, 09.10.2016
3+
4+
* Client/AMQP/MQTT: Remove deprecated `sendToQueue()`.
5+
6+
# msgflo-nodejs 0.6.0, 10.09.2016
7+
8+
* participant: Remove deprecated `connectGraphEdges()` and `connectGraphFile()`.
9+
Should use `msgflo.setup` instead.
10+
* MQTT: Implement `removeBinding()`, for removing a connection
11+
212
# msgflo-nodejs 0.5.0, 06.06.2016
313

414
* Allows to register custom transports using `msgflo_nodejs.transport.register()`

spec/01transport.coffee

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ createBindQueues = (broker, queueMapping, callback) ->
6464
sendPackets = (packets, callback) ->
6565
send = (p, cb) ->
6666
[client, queue, data] = p
67-
client.sendToQueue queue, data, cb
67+
client.sendTo 'outqueue', queue, data, cb
6868

6969
async.map packets, send, callback
7070

@@ -128,7 +128,7 @@ transportTests = (type) ->
128128
], (err) ->
129129
chai.expect(err).to.not.exist
130130

131-
clients.sender.sendToQueue outQueue, payload, (err) ->
131+
clients.sender.sendTo 'outqueue', outQueue, payload, (err) ->
132132
chai.expect(err).to.not.exist
133133
done()
134134

@@ -149,7 +149,7 @@ transportTests = (type) ->
149149

150150
clients.receiver.subscribeToQueue sharedQueue, onReceive, (err) ->
151151
chai.expect(err).to.be.a 'null'
152-
clients.sender.sendToQueue sharedQueue, payload, (err) ->
152+
clients.sender.sendTo 'outqueue', sharedQueue, payload, (err) ->
153153
chai.expect(err).to.be.a 'null'
154154

155155

@@ -173,7 +173,7 @@ transportTests = (type) ->
173173

174174
clients.receiver.subscribeToQueue sharedQueue, onReceive, (err) ->
175175
chai.expect(err).to.be.a 'null'
176-
clients.sender.sendToQueue sharedQueue, payload, (err) ->
176+
clients.sender.sendTo 'outqueue', sharedQueue, payload, (err) ->
177177
chai.expect(err).to.be.a 'null'
178178

179179

@@ -293,7 +293,7 @@ transportTests = (type) ->
293293
handlers.push [ clients[name], name, onReceives[name] ]
294294
subscribeData handlers, (err) ->
295295
chai.expect(err).to.not.exist
296-
clients.sender.sendToQueue outQueue2, {data: 'ident'}, (err) ->
296+
clients.sender.sendTo 'outqueue', outQueue2, {data: 'ident'}, (err) ->
297297
chai.expect(err).to.not.exist
298298

299299
describeIfRoundRobinSupport 'Roundrobin binding', ->

src/amqp.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ class Client extends interfaces.MessagingClient
146146
payload: part
147147
@channel.assertQueue 'fbp'
148148
data = new Buffer JSON.stringify msg
149-
@channel.sendToQueue 'fbp', data
149+
@channel.sendTo 'inqueue', 'fbp', data
150150
return callback null
151151

152152
class MessageBroker extends Client

src/direct.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class MessageBroker extends interfaces.MessageBroker
102102

103103
## Sending/Receiving messages
104104
sendTo: (type, queueName, message, callback) ->
105-
# console.log 'broker sendToQueue', queueName, Object.keys(@queues), @queues[queueName]
105+
debug 'broker sendTo', queueName
106106
@queues[queueName].send message
107107
return callback null
108108

src/interfaces.coffee

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,10 @@ class MessagingSystem
2020
throw new Error 'Not Implemented'
2121

2222
## Sending/Receiving messages
23+
# queueName must be created beforehand, and be of correct type
2324
sendTo: (type, name, message, callback) ->
2425
throw new Error 'Not Implemented'
2526

26-
# queueName must be created beforehand, and be of correct type
27-
sendToQueue: (queueName, message, callback) ->
28-
console.log 'WARN: sendToQueue is deprecated. Use sendTo() instead'
29-
@sendTo 'outqueue', queueName, message, callback
30-
3127
# handler must call ackMessage() on succesful processing of a message
3228
subscribeToQueue: (queueName, handler, callback) ->
3329
throw new Error 'Not Implemented'

src/mqtt.coffee

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class Client extends interfaces.MessagingClient
106106
protocol: 'discovery'
107107
command: 'participant'
108108
payload: part
109-
@sendToQueue 'fbp', msg, callback
109+
@sendTo 'inqueue', 'fbp', msg, callback
110110

111111
class MessageBroker extends Client
112112
constructor: (address, options) ->

0 commit comments

Comments
 (0)