Skip to content

Commit 0b7cabd

Browse files
authored
Merge pull request #545 from redboltz/fix_544
Fix 544
2 parents 85a0404 + 22780a6 commit 0b7cabd

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ ELSE ()
5252
IF ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
5353
IF ((CMAKE_CXX_COMPILER_VERSION VERSION_GREATER ${GNUCXX_STD_SUPPORT_VERSION}) OR
5454
(CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL ${GNUCXX_STD_SUPPORT_VERSION}))
55-
SET (CMAKE_CXX_FLAGS "-std=c++03 ${CMAKE_CXX_FLAGS}")
55+
SET (CMAKE_CXX_FLAGS "-std=c++98 ${CMAKE_CXX_FLAGS}")
5656
ENDIF ()
5757
ELSEIF ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
58-
SET (CMAKE_CXX_FLAGS "-std=c++03 ${CMAKE_CXX_FLAGS}")
58+
SET (CMAKE_CXX_FLAGS "-std=c++98 ${CMAKE_CXX_FLAGS}")
5959
ELSEIF ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
6060
IF (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 18)
6161
SET (CMAKE_CXX_FLAGS "-DMSGPACK_USE_CPP03 ${CMAKE_CXX_FLAGS}")

test/user_class.cpp

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,26 +148,30 @@ class TestUnionMemberClass
148148

149149
void msgpack_unpack(msgpack::object o)
150150
{
151-
msgpack::type::tuple<bool, msgpack::object> tuple;
152-
o.convert(tuple);
153-
154151
#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
155152
#pragma GCC diagnostic push
156153
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
157154
#endif // (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
155+
msgpack::type::tuple<bool, msgpack::object> tuple;
156+
o.convert(tuple);
157+
158158
is_double = tuple.get<0>();
159-
#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
160-
#pragma GCC diagnostic pop
161-
#endif // (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
162159
if (is_double)
163160
tuple.get<1>().convert(value.f);
164161
else
165162
tuple.get<1>().convert(value.i);
163+
#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
164+
#pragma GCC diagnostic pop
165+
#endif // (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
166166
}
167167
};
168168

169169
TEST(MSGPACK_USER_DEFINED, simple_buffer_union_member)
170170
{
171+
#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
172+
#pragma GCC diagnostic push
173+
#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
174+
#endif // (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
171175
{
172176
// double
173177
TestUnionMemberClass val1(1.0);
@@ -191,6 +195,9 @@ TEST(MSGPACK_USER_DEFINED, simple_buffer_union_member)
191195
EXPECT_EQ(val1.value.i, 1);
192196
EXPECT_EQ(val1.value.i, val2.value.i);
193197
}
198+
#if (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
199+
#pragma GCC diagnostic pop
200+
#endif // (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6)) && !defined(__clang__)
194201
}
195202

196203
// inheritance

0 commit comments

Comments
 (0)