Updated cmake minimum required to 3.5-4.0

redboltz · redboltz · commit 4a0c25312221 · 2025-05-18T20:29:50.000+09:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,12 +1,4 @@
-if(${CMAKE_VERSION} VERSION_GREATER "3.4")
-    CMAKE_MINIMUM_REQUIRED (VERSION 3.5)
-else()
-    CMAKE_MINIMUM_REQUIRED (VERSION 2.8.12)
-    IF ((CMAKE_VERSION VERSION_GREATER 3.1) OR
-        (CMAKE_VERSION VERSION_EQUAL 3.1))
-        CMAKE_POLICY(SET CMP0054 NEW)
-    ENDIF ()
-endif()
+CMAKE_MINIMUM_REQUIRED (VERSION 3.5...4.0)
 
 PROJECT (msgpack-cxx LANGUAGES CXX)
 
diff --git a/cmake/CodeCoverage.cmake b/cmake/CodeCoverage.cmake
@@ -48,7 +48,7 @@ FUNCTION(SETUP_TARGET_FOR_COVERAGE _targetname _testrunner _outputname)
 
     # Show info where to find the report
     ADD_CUSTOM_COMMAND(TARGET ${_targetname} POST_BUILD
-        COMMAND ;
+        COMMAND ${CMAKE_COMMAND} -E echo ""
         COMMENT "Open ./${_outputname}/index.html in your browser to view the coverage report."
     )
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ FUNCTION(SETUP_TARGET_FOR_COVERAGE _targetname _testrunner _outputname)`
`48`	`48`
`49`	`49`	`# Show info where to find the report`
`50`	`50`	`ADD_CUSTOM_COMMAND(TARGET ${_targetname} POST_BUILD`
`51`		`- COMMAND ;`
	`51`	`+ COMMAND ${CMAKE_COMMAND} -E echo ""`
`52`	`52`	`COMMENT "Open ./${_outputname}/index.html in your browser to view the coverage report."`
`53`	`53`	`)`
`54`	`54`