Skip to content

Commit 57b030a

Browse files
committed
Merge pull request #347 from redboltz/update_comment
Updated comments to describe #if !define(_MSC_VER) reason.
2 parents 9c0f629 + 018c6c8 commit 57b030a

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

test/boost_fusion.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,12 @@ BOOST_FUSION_ADAPT_STRUCT(
140140
f3 // *3
141141
)
142142

143-
#if !defined(_MSC_VER)
144143

145-
// boost::fusion's adaptor uses std::tuple.
146144
// MSVC2015's std::tuple requires default constructor during 'as' process.
147-
// I don't know why...
145+
// It doesn't support Expression SFINAE yet, then 'as' is fallbacked to 'convert'.
146+
// After MSVC would support Expression SFINAE, remove this guard.
147+
#if !defined(_MSC_VER)
148+
148149
TEST(MSGPACK_BOOST, pack_convert_no_def_con)
149150
{
150151
std::stringstream ss;

test/msgpack_cpp11.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,10 +456,13 @@ TEST(MSGPACK_NO_DEF_CON_PAIR, simple_buffer)
456456
EXPECT_EQ(val1, val2);
457457
}
458458

459-
#if !defined(_MSC_VER)
459+
460460

461461
// MSVC2015's std::tuple requires default constructor during 'as' process.
462-
// I don't know why...
462+
// It doesn't support Expression SFINAE yet, then 'as' is fallbacked to 'convert'.
463+
// After MSVC would support Expression SFINAE, remove this guard.
464+
#if !defined(_MSC_VER)
465+
463466
TEST(MSGPACK_NO_DEF_CON_TUPLE, simple_buffer)
464467
{
465468
std::tuple<no_def_con, no_def_con, no_def_con_composite> val1 {1, 2, 3};

0 commit comments

Comments
 (0)