Skip to content

Commit e50cc5d

Browse files
committed
Fixed warnings on MSVC.
1 parent 4501551 commit e50cc5d

File tree

5 files changed

+18
-8
lines changed

5 files changed

+18
-8
lines changed

test/buffer.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,12 @@ TEST(buffer, zbuffer_c)
9292

9393
TEST(buffer, fbuffer)
9494
{
95+
#if defined(_MSC_VER)
96+
FILE* file;
97+
tmpfile_s(&file);
98+
#else // defined(_MSC_VER)
9599
FILE* file = tmpfile();
100+
#endif // defined(_MSC_VER)
96101
EXPECT_TRUE( file != NULL );
97102

98103
msgpack::fbuffer fbuf(file);
@@ -116,7 +121,13 @@ TEST(buffer, fbuffer)
116121

117122
TEST(buffer, fbuffer_c)
118123
{
124+
#if defined(_MSC_VER)
125+
FILE* file;
126+
tmpfile_s(&file);
127+
#else // defined(_MSC_VER)
119128
FILE* file = tmpfile();
129+
#endif // defined(_MSC_VER)
130+
120131
void* fbuf = (void*)file;
121132

122133
EXPECT_TRUE( file != NULL );

test/cases.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ static void feed_file(msgpack::unpacker& pac, const char* path)
1111
if(fin.bad()) {
1212
throw std::runtime_error("read failed");
1313
}
14-
pac.buffer_consumed(fin.gcount());
14+
pac.buffer_consumed(static_cast<size_t>(fin.gcount()));
1515
if(fin.fail()) {
1616
break;
1717
}
@@ -35,4 +35,3 @@ TEST(cases, format)
3535

3636
EXPECT_FALSE( pac_compact.next(&result) );
3737
}
38-

test/msgpack_basic.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,7 @@ TEST(MSGPACK_STL, simple_buffer_non_const_cstring)
585585
val1 += 'a' + rand() % 26;
586586
msgpack::sbuffer sbuf;
587587
char* s = new char[val1.size() + 1];
588-
std::strcpy(s, val1.c_str());
588+
std::memcpy(s, val1.c_str(), val1.size() + 1);
589589
msgpack::pack(sbuf, s);
590590
delete [] s;
591591
msgpack::unpacked ret;

test/raw.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ TEST(MSGPACK_RAW_REF, pack_unpack_16_h)
9292
msgpack::pack(ss, rr1);
9393
std::string packed_str = ss.str();
9494
EXPECT_EQ(packed_str[0], static_cast<char>(0xc5u));
95-
EXPECT_EQ(packed_str[1], static_cast<char>(0xff));
96-
EXPECT_EQ(packed_str[2], static_cast<char>(0xff));
95+
EXPECT_EQ(packed_str[1], static_cast<char>(0xffu));
96+
EXPECT_EQ(packed_str[2], static_cast<char>(0xffu));
9797
EXPECT_EQ(packed_str[3], 'A');
9898

9999
msgpack::unpacked upd;

test/streaming.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class event_handler {
156156
while(true) {
157157
pac.reserve_buffer(32*1024);
158158

159-
size_t len = input.readsome(pac.buffer(), pac.buffer_capacity());
159+
size_t len = static_cast<size_t>(input.readsome(pac.buffer(), pac.buffer_capacity()));
160160

161161
if(len == 0) {
162162
return;
@@ -226,7 +226,7 @@ TEST(streaming, basic_compat)
226226
while(count < 3) {
227227
pac.reserve_buffer(32*1024);
228228

229-
size_t len = input.readsome(pac.buffer(), pac.buffer_capacity());
229+
size_t len = static_cast<size_t>(input.readsome(pac.buffer(), pac.buffer_capacity()));
230230
pac.buffer_consumed(len);
231231

232232
while(pac.execute()) {
@@ -262,7 +262,7 @@ class event_handler_compat {
262262
while(true) {
263263
pac.reserve_buffer(32*1024);
264264

265-
size_t len = input.readsome(pac.buffer(), pac.buffer_capacity());
265+
size_t len = static_cast<size_t>(input.readsome(pac.buffer(), pac.buffer_capacity()));
266266

267267
if(len == 0) {
268268
return;

0 commit comments

Comments
 (0)