Fix build settings for debugger to read pdb correctly.

This commit adjust build options to avoid Visual Studio error, specifically it
fails to show stack trace with "jump to the source code" feature enabled.
It should be caused by portable pdb for .NET Framework projects, so this commit
fixes common prop file to generate legacy pdb for debug build.

This commit also fix NUnit related PDB reader error with adding latest (beta)
Mono.Cecil reference.

Author: yfakariya

MsgPack.Common.props

@@ -43,15 +43,19 @@
     <DocumentationFile>$(OutputPath)\$(TargetFramework)\$(AssemblyName).XML</DocumentationFile>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == 'uap10.0'">
+    <DebugType>pdbonly</DebugType>
     <DefineConstants>$(DefineConstants);FEATURE_TAP;FEATURE_CONCURRENT</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == 'net35'">
+    <DebugType>pdbonly</DebugType>
     <DefineConstants>$(DefineConstants);FEATURE_POINTER_CONVERSION</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == 'net45'">
+    <DebugType>pdbonly</DebugType>
     <DefineConstants>$(DefineConstants);FEATURE_TAP;FEATURE_CONCURRENT;FEATURE_POINTER_CONVERSION</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == 'net46'">
+    <DebugType>pdbonly</DebugType>
     <DefineConstants>$(DefineConstants);FEATURE_TAP;FEATURE_CONCURRENT;FEATURE_POINTER_CONVERSION;FEATURE_MEMCOPY</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition="'$(TargetFramework)' == 'netstandard1.1'">
@@ -79,4 +83,7 @@
   <PropertyGroup Condition="'$(TargetFramework)' == 'uap10.0'">
     <DefineConstants>$(DefineConstants);NETFX_CORE;WINDOWS_UWP;NETSTANDARD1_3;AOT</DefineConstants>
   </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
+    <DebugType>full</DebugType>
+  </PropertyGroup>
 </Project>

test/MsgPack.UnitTest.BclExtensions/MsgPack.UnitTest.BclExtensions.csproj

@@ -25,6 +25,8 @@
     <PackageReference Include="FSharp.Core" Version="4.2.2 " />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="2.3.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
+    <!-- To avoid PDB Reader error -->
+    <PackageReference Include="Mono.Cecil" Version="0.10.0-beta6" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.0'">
     <PackageReference Include="Microsoft.NETCore.App" Version="1.0.5" />

test/MsgPack.UnitTest.CodeDom/MsgPack.UnitTest.CodeDom.csproj

@@ -19,6 +19,8 @@
     <PackageReference Include="NUnit3TestAdapter" Version="3.8.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="2.3.1" />
+    <!-- To avoid PDB Reader error -->
+    <PackageReference Include="Mono.Cecil" Version="0.10.0-beta6" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp2.0'">
     <PackageReference Include="Microsoft.NETCore.App" Version="2.0.0" />

test/MsgPack.UnitTest/MsgPack.UnitTest.csproj

@@ -23,6 +23,8 @@
     <PackageReference Include="NUnit3TestAdapter" Version="3.8.0" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="2.3.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
+    <!-- To avoid PDB Reader error -->
+    <PackageReference Include="Mono.Cecil" Version="0.10.0-beta6" />
   </ItemGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp1.0'">
     <PackageReference Include="Microsoft.NETCore.App" Version="1.0.5" />