Fix failed to create serializer for type which have indexer(s) and do not implement IDictionary. Issue #49

Author: yfakariya

src/MsgPack/Serialization/SerializationTarget.cs

@@ -203,6 +203,12 @@ private static bool CheckTargetEligibility( MemberInfo member )
 
 			if ( asProperty != null )
 			{
+				if ( asProperty.GetIndexParameters().Length > 0 )
+				{
+					// Indexer cannot be target except the type itself implements IDictionary or IDictionary<TKey,TValue>
+					return false;
+				}
+
 #if !NETFX_CORE
 				if ( asProperty.GetSetMethod( true ) != null )
 #else

test/MsgPack.UnitTest/Serialization/SerializationTargetTest.cs

@@ -107,6 +107,12 @@ public void TestAliasInDataMember()
 			Assert.That( target.Any( m => m.Contract.Name == "Alias" && m.Contract.Name != m.Member.Name ) );
 		}
 
+		[Test]
+		public void TestIndexerOverload()
+		{
+			Assert.That( SerializationTarget.GetTargetMembers( typeof( WithIndexerOverload ) ).Any(), Is.False );
+		}
+
 		[Test]
 		public void TestDuplicatedKey()
 		{

test/MsgPack.UnitTest/Serialization/SerializationTargets.cs

@@ -247,6 +247,22 @@ public DataMamberClass()
 #endif // !NETFX_CORE && !SILVERLIGHT
 		}
 	}
+
+	public class WithIndexerOverload
+	{
+		public string this[ int index ]
+		{
+			get { return null; }
+			set { }
+		}
+
+		public string this[ string key ]
+		{
+			get { return null; }
+			set { }
+		}
+	}
+
 	public class WithKeyDuplicate
 	{
 		[MessagePackMember( 0, Name = "Boo" )]