Skip to content

Commit 9ecdd63

Browse files
yfakariyayfakariya
committed
Change polymorphism type-info format.
From discussion in twitter, ext type should not be used to represent type info to avoid complexity of interop implementation in both sides. And known type code should be string to respect existing implementation.
1 parent 8a81e63 commit 9ecdd63

File tree

477 files changed

+4827
-5053
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

477 files changed

+4827
-5053
lines changed

‎src/MsgPack.Net35/MsgPack.Net35.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,9 @@
869869
<Compile Include="..\MsgPack\StreamPacker.cs">
870870
<Link>StreamPacker.cs</Link>
871871
</Compile>
872+
<Compile Include="..\MsgPack\StringEscape.cs">
873+
<Link>StringEscape.cs</Link>
874+
</Compile>
872875
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
873876
<Link>SubtreeUnpacker.cs</Link>
874877
</Compile>

‎src/MsgPack.Net40/MsgPack.Net40.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -910,6 +910,9 @@
910910
<Compile Include="..\MsgPack\StreamPacker.cs">
911911
<Link>StreamPacker.cs</Link>
912912
</Compile>
913+
<Compile Include="..\MsgPack\StringEscape.cs">
914+
<Link>StringEscape.cs</Link>
915+
</Compile>
913916
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
914917
<Link>SubtreeUnpacker.cs</Link>
915918
</Compile>

‎src/MsgPack.Silverlight.5/MsgPack.Silverlight.5.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -880,6 +880,9 @@
880880
<Compile Include="..\MsgPack\StreamPacker.cs">
881881
<Link>StreamPacker.cs</Link>
882882
</Compile>
883+
<Compile Include="..\MsgPack\StringEscape.cs">
884+
<Link>StringEscape.cs</Link>
885+
</Compile>
883886
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
884887
<Link>SubtreeUnpacker.cs</Link>
885888
</Compile>

‎src/MsgPack.Silverlight.WindowsPhone/MsgPack.Silverlight.WindowsPhone.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -823,6 +823,9 @@
823823
<Compile Include="..\MsgPack\StreamPacker.cs">
824824
<Link>StreamPacker.cs</Link>
825825
</Compile>
826+
<Compile Include="..\MsgPack\StringEscape.cs">
827+
<Link>StringEscape.cs</Link>
828+
</Compile>
826829
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
827830
<Link>SubtreeUnpacker.cs</Link>
828831
</Compile>

‎src/MsgPack.Unity3D.Full/MsgPack.Unity3D.Full.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -592,6 +592,9 @@
592592
<Compile Include="..\MsgPack\StreamPacker.cs">
593593
<Link>StreamPacker.cs</Link>
594594
</Compile>
595+
<Compile Include="..\MsgPack\StringEscape.cs">
596+
<Link>StringEscape.cs</Link>
597+
</Compile>
595598
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
596599
<Link>SubtreeUnpacker.cs</Link>
597600
</Compile>

‎src/MsgPack.Unity3D/MsgPack.Unity3D.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,9 @@
613613
<Compile Include="..\MsgPack\StreamPacker.cs">
614614
<Link>StreamPacker.cs</Link>
615615
</Compile>
616+
<Compile Include="..\MsgPack\StringEscape.cs">
617+
<Link>StringEscape.cs</Link>
618+
</Compile>
616619
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
617620
<Link>SubtreeUnpacker.cs</Link>
618621
</Compile>

‎src/MsgPack.WinRT.Portable/MsgPack.WinRT.Portable.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -763,6 +763,9 @@
763763
<Compile Include="..\MsgPack\StreamPacker.cs">
764764
<Link>StreamPacker.cs</Link>
765765
</Compile>
766+
<Compile Include="..\MsgPack\StringEscape.cs">
767+
<Link>StringEscape.cs</Link>
768+
</Compile>
766769
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
767770
<Link>SubtreeUnpacker.cs</Link>
768771
</Compile>

‎src/MsgPack.Xamarin.Android/MsgPack.Xamarin.Android.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,9 @@
620620
<Compile Include="..\MsgPack\StreamPacker.cs">
621621
<Link>StreamPacker.cs</Link>
622622
</Compile>
623+
<Compile Include="..\MsgPack\StringEscape.cs">
624+
<Link>StringEscape.cs</Link>
625+
</Compile>
623626
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
624627
<Link>SubtreeUnpacker.cs</Link>
625628
</Compile>

‎src/MsgPack.Xamarin.iOS/MsgPack.Xamarin.iOS.csproj‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,9 @@
614614
<Compile Include="..\MsgPack\StreamPacker.cs">
615615
<Link>StreamPacker.cs</Link>
616616
</Compile>
617+
<Compile Include="..\MsgPack\StringEscape.cs">
618+
<Link>StringEscape.cs</Link>
619+
</Compile>
617620
<Compile Include="..\MsgPack\SubtreeUnpacker.cs">
618621
<Link>SubtreeUnpacker.cs</Link>
619622
</Compile>

‎src/MsgPack/KnownExtTypeCode.cs‎

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,6 @@ namespace MsgPack
3131
/// </remarks>
3232
public static class KnownExtTypeCode
3333
{
34-
/// <summary>
35-
/// Gets the ext type code which represents "Library Defined Type".
36-
/// </summary>
37-
/// <value>
38-
/// 0.
39-
/// </value>
40-
/// <remarks>
41-
/// "Library Defined Type" will be used to embed native or coded type information in MessagePack stream.
42-
/// </remarks>
43-
public static byte LibraryDefinedType
44-
{
45-
get { return 0; }
46-
}
47-
4834
/// <summary>
4935
/// Gets the ext type code which represents multidimensional array.
5036
/// </summary>
@@ -53,7 +39,7 @@ public static byte LibraryDefinedType
5339
/// </value>
5440
public static byte MultidimensionalArray
5541
{
56-
get { return 0x1; }
42+
get { return 0x71; }
5743
}
5844
}
5945
}

0 commit comments

Comments
 (0)