Skip to content

Commit 0f90a3a

Browse files
committed
remove endianness spec from single-byte field
1 parent 704d75e commit 0f90a3a

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/msgpack_packer.erl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -376,17 +376,17 @@ pack_ext(Any, Packer, Opt) ->
376376
case Packer(Any, Opt) of
377377
{ok, {Type, Data}} when -16#80 =< Type andalso Type =< 16#7F ->
378378
Bin = case byte_size(Data) of
379-
1 -> <<16#D4, Type:1/little-signed-integer-unit:8, Data/binary>>;
380-
2 -> <<16#D5, Type:1/little-signed-integer-unit:8, Data/binary>>;
381-
4 -> <<16#D6, Type:1/little-signed-integer-unit:8, Data/binary>>;
382-
8 -> <<16#D7, Type:1/little-signed-integer-unit:8, Data/binary>>;
383-
16 -> <<16#D8, Type:1/little-signed-integer-unit:8, Data/binary>>;
379+
1 -> <<16#D4, Type:1/signed-integer-unit:8, Data/binary>>;
380+
2 -> <<16#D5, Type:1/signed-integer-unit:8, Data/binary>>;
381+
4 -> <<16#D6, Type:1/signed-integer-unit:8, Data/binary>>;
382+
8 -> <<16#D7, Type:1/signed-integer-unit:8, Data/binary>>;
383+
16 -> <<16#D8, Type:1/signed-integer-unit:8, Data/binary>>;
384384
Len when Len < 16#100 ->
385-
<<16#C7, Len:8, Type:1/little-signed-integer-unit:8, Data/binary>>;
385+
<<16#C7, Len:8, Type:1/signed-integer-unit:8, Data/binary>>;
386386
Len when Len < 16#10000 ->
387-
<<16#C8, Len:16, Type:1/little-signed-integer-unit:8, Data/binary>>;
387+
<<16#C8, Len:16, Type:1/signed-integer-unit:8, Data/binary>>;
388388
Len when Len < 16#100000000 ->
389-
<<16#C9, Len:32, Type:1/little-signed-integer-unit:8, Data/binary>>
389+
<<16#C9, Len:32, Type:1/signed-integer-unit:8, Data/binary>>
390390
end,
391391
{ok, Bin};
392392
{error, E} ->

src/msgpack_unpacker.erl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -126,42 +126,42 @@ unpack_stream(<<16#C1, _R/binary>>, _) -> throw({badarg, 16#C1});
126126
%% for extention types
127127

128128
%% fixext 1 stores an integer and a byte array whose length is 1 byte
129-
unpack_stream(<<16#D4, T:1/little-signed-integer-unit:8, Data:1/binary, Rest/binary>>,
129+
unpack_stream(<<16#D4, T:1/signed-integer-unit:8, Data:1/binary, Rest/binary>>,
130130
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
131131
maybe_unpack_ext(16#D4, Unpack, T, Data, Rest, Orig);
132132

133133
%% fixext 2 stores an integer and a byte array whose length is 2 bytes
134-
unpack_stream(<<16#D5, T:1/little-signed-integer-unit:8, Data:2/binary, Rest/binary>>,
134+
unpack_stream(<<16#D5, T:1/signed-integer-unit:8, Data:2/binary, Rest/binary>>,
135135
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
136136
maybe_unpack_ext(16#D5, Unpack, T, Data, Rest, Orig);
137137

138138
%% fixext 4 stores an integer and a byte array whose length is 4 bytes
139-
unpack_stream(<<16#D6, T:1/little-signed-integer-unit:8, Data:4/binary, Rest/binary>>,
139+
unpack_stream(<<16#D6, T:1/signed-integer-unit:8, Data:4/binary, Rest/binary>>,
140140
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
141141
maybe_unpack_ext(16#D6, Unpack, T, Data, Rest, Orig);
142142

143143
%% fixext 8 stores an integer and a byte array whose length is 8 bytes
144-
unpack_stream(<<16#D7, T:1/little-signed-integer-unit:8, Data:8/binary, Rest/binary>>,
144+
unpack_stream(<<16#D7, T:1/signed-integer-unit:8, Data:8/binary, Rest/binary>>,
145145
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
146146
maybe_unpack_ext(16#D7, Unpack, T, Data, Rest, Orig);
147147

148148
%% fixext 16 stores an integer and a byte array whose length is 16 bytes
149-
unpack_stream(<<16#D8, T:1/little-signed-integer-unit:8, Data:16/binary, Rest/binary>>,
149+
unpack_stream(<<16#D8, T:1/signed-integer-unit:8, Data:16/binary, Rest/binary>>,
150150
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
151151
maybe_unpack_ext(16#D8, Unpack, T, Data, Rest, Orig);
152152

153153
%% ext 8 stores an integer and a byte array whose length is upto (2^8)-1 bytes:
154-
unpack_stream(<<16#C7, Len:8, Type:1/little-signed-integer-unit:8, Data:Len/binary, Rest/binary>>,
154+
unpack_stream(<<16#C7, Len:8, Type:1/signed-integer-unit:8, Data:Len/binary, Rest/binary>>,
155155
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
156156
maybe_unpack_ext(16#C7, Unpack, Type, Data, Rest, Orig);
157157

158158
%% ext 16 stores an integer and a byte array whose length is upto (2^16)-1 bytes:
159-
unpack_stream(<<16#C8, Len:16, Type:1/little-signed-integer-unit:8, Data:Len/binary, Rest/binary>>,
159+
unpack_stream(<<16#C8, Len:16, Type:1/signed-integer-unit:8, Data:Len/binary, Rest/binary>>,
160160
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
161161
maybe_unpack_ext(16#C8, Unpack, Type, Data, Rest, Orig);
162162

163163
%% ext 32 stores an integer and a byte array whose length is upto (2^32)-1 bytes:
164-
unpack_stream(<<16#C9, Len:32, Type:1/little-signed-integer-unit:8, Data:Len/binary, Rest/binary>>,
164+
unpack_stream(<<16#C9, Len:32, Type:1/signed-integer-unit:8, Data:Len/binary, Rest/binary>>,
165165
?OPTION{ext_unpacker=Unpack, original_list=Orig} = _Opt) ->
166166
maybe_unpack_ext(16#C9, Unpack, Type, Data, Rest, Orig);
167167

0 commit comments

Comments
 (0)