fix UB

m6w6 · m6w6 · commit a1368f11432c · 2024-08-20T16:15:40.000+02:00
diff --git a/msgpack_unpack.c b/msgpack_unpack.c
@@ -68,7 +68,7 @@ typedef struct var_entries {
 #define MSGPACK_VALIDATE_INPUT_DATA_LENGTH(data, len, eof) \
     ((data) + (len) <= (eof))
 #define MSGPACK_VALIDATE_INPUT(user, data, len) \
-    if (!MSGPACK_VALIDATE_INPUT_DATA_LENGTH(data, len, (user)->eof)) { \
+    if ((len && !data) || !MSGPACK_VALIDATE_INPUT_DATA_LENGTH(data, len, (user)->eof)) { \
         return MSGPACK_UNPACK_PARSE_ERROR; \
     }
 

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ typedef struct var_entries {`
`68`	`68`	`#define MSGPACK_VALIDATE_INPUT_DATA_LENGTH(data, len, eof) \`
`69`	`69`	`((data) + (len) <= (eof))`
`70`	`70`	`#define MSGPACK_VALIDATE_INPUT(user, data, len) \`
`71`		`- if (!MSGPACK_VALIDATE_INPUT_DATA_LENGTH(data, len, (user)->eof)) { \`
	`71`	`+ if ((len && !data) \|\| !MSGPACK_VALIDATE_INPUT_DATA_LENGTH(data, len, (user)->eof)) { \`
`72`	`72`	`return MSGPACK_UNPACK_PARSE_ERROR; \`
`73`	`73`	`}`
`74`	`74`