do not make references indirect in var_replace

mheijkoop · Sean-Der · commit e93208843dbd · 2016-12-06T21:23:26.000-06:00
workaround for #94, possibly at the expense of leaking a bit of memory?
diff --git a/msgpack_unpack.c b/msgpack_unpack.c
@@ -92,7 +92,7 @@ static zval *msgpack_var_push(msgpack_unserialize_data_t *var_hashx) /* {{{ */ {
 /* }}} */
 
 static inline void msgpack_var_replace(zval *old, zval *new) /* {{{ */ {
-	if (!MSGPACK_IS_STACK_VALUE(old)) {
+	if (!MSGPACK_IS_STACK_VALUE(old) && Z_TYPE_P(old) != IS_REFERENCE) {
 		ZVAL_INDIRECT(old, new);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ static zval msgpack_var_push(msgpack_unserialize_data_t var_hashx) /* {{{ */ {`
`92`	`92`	`/* }}} */`
`93`	`93`
`94`	`94`	`static inline void msgpack_var_replace(zval old, zval new) /* {{{ */ {`
`95`		`- if (!MSGPACK_IS_STACK_VALUE(old)) {`
	`95`	`+ if (!MSGPACK_IS_STACK_VALUE(old) && Z_TYPE_P(old) != IS_REFERENCE) {`
`96`	`96`	`ZVAL_INDIRECT(old, new);`
`97`	`97`	`}`
`98`	`98`	`}`