Skip to content

Commit edcaeda

Browse files
committed
ZEND_HASH_FOREACH_KEY_VAL -> ZEND_HASH_FOREACH_STR_KEY_VAL ulong key was unused
1 parent fd19e23 commit edcaeda

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

msgpack.c

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,8 @@ static ZEND_MINIT_FUNCTION(msgpack)
9393

9494
msgpack_init_class();
9595

96-
#if (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION < 1)
97-
REGISTER_LONG_CONSTANT(
98-
"MESSAGEPACK_OPT_PHPONLY", MSGPACK_CLASS_OPT_PHPONLY,
99-
CONST_CS | CONST_PERSISTENT);
100-
#endif
96+
REGISTER_LONG_CONSTANT("MESSAGEPACK_OPT_PHPONLY",
97+
MSGPACK_CLASS_OPT_PHPONLY, CONST_CS | CONST_PERSISTENT);
10198

10299
return SUCCESS;
103100
}
@@ -161,7 +158,6 @@ PS_SERIALIZER_DECODE_FUNC(msgpack)
161158
{
162159
int ret;
163160
zend_string *key_str;
164-
ulong key_long;
165161
zval tmp, *value;
166162
size_t off = 0;
167163
msgpack_unpack_t mp;
@@ -180,7 +176,7 @@ PS_SERIALIZER_DECODE_FUNC(msgpack)
180176
msgpack_unserialize_set_return_value(&var_hash, &tmp);
181177
msgpack_unserialize_var_destroy(&var_hash, 0);
182178

183-
ZEND_HASH_FOREACH_KEY_VAL(HASH_OF(&tmp), key_long, key_str, value) {
179+
ZEND_HASH_FOREACH_STR_KEY_VAL(HASH_OF(&tmp), key_str, value) {
184180
if (key_str) {
185181
php_set_session_var(key_str, value, NULL);
186182
php_add_session_var(key_str);
@@ -189,8 +185,7 @@ PS_SERIALIZER_DECODE_FUNC(msgpack)
189185
}
190186
} ZEND_HASH_FOREACH_END();
191187
zval_ptr_dtor(&tmp);
192-
}
193-
else {
188+
} else {
194189
msgpack_unserialize_var_destroy(&var_hash, 1);
195190
}
196191

0 commit comments

Comments
 (0)