Skip to content

Commit 93c32bc

Browse files
authored
Merge pull request LANL-Bioinformatics#9 from mshakya/master
minor bug fixes
2 parents 877950e + 5937e2c commit 93c32bc

15 files changed

+143
-59
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,5 @@ thirdParty/evolver.out
2626
thirdParty/errors.log
2727
messages.log
2828
*.log
29-
docs/_build/*
29+
docs/_build/*
30+
.vscode/

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,9 @@ Then test phame to see if the installation was complete using a short test run:
7777

7878
## CITATION
7979

80-
From raw reads to trees: Whole genome SNP phylogenetics across the tree of life.
80+
Shakya, M., Ahmed. S.A, Davenport K.W., Flynn M.C., Lo. C-C, Chain P.S.G. Standardized phylogenetic and molecular evolutionary analysis applied to species across the microbial tree of life. Sci. Rep. 10, 1723 (2020).
8181

82-
Sanaa Afroz Ahmed, Chien-Chi Lo, Po-E Li, Karen W Davenport, Patrick S.G. Chain
83-
84-
bioRxiv doi: http://dx.doi.org/10.1101/032250
82+
doi: https://doi.org/10.1038/s41598-020-58356-1
8583

8684
--------------------------------------------------------------
8785
## Contact

lib/PhaME.pm

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -593,6 +593,7 @@ sub buildTree {
593593
my $thread = shift;
594594
my $tree = shift;
595595
my $name = shift;
596+
my $bsignal = shift; # signal showing if bootstrap should be done or not.
596597
my $bootstrap = shift;
597598
my $error = shift;
598599
my $log = shift;
@@ -616,11 +617,25 @@ sub buildTree {
616617
# = "raxmlHPC-PTHREADS -p 10 -T $thread -m GTRGAMMAI -s $outdir/$name\_snp_alignment.fna -w $outdir -n $name 2>>$error >> $log\n\n";
617618
print OUT $raxml;
618619
if ( system($raxml) ) { die "Error running $raxml.\n"; }
620+
if ( $bsignal == 1 ) {
621+
open( OUT, ">>$log" );
622+
my $bootTrees
623+
= "raxmlHPC-PTHREADS -p 10 -T $thread -m GTRGAMMAI -b 10000 -t $outdir/RAxML_bestTree.$name -s $outdir/$name\_all_alignment.fna -w $outdir -N $bootstrap -n $name\_b -k 2>>$error >> $log\n\n";
624+
print OUT $bootTrees;
625+
if ( system($bootTrees) ) { die "Error running $bootTrees.\n"; }
626+
my $bestTree
627+
= "raxmlHPC-PTHREADS -p 10 -T $thread -f b -m GTRGAMMAI -t $outdir/RAxML_bestTree.$name -s $outdir/$name\_all_alignment.fna -z $outdir/RAxML_bootstrap.$name\_b -w $outdir -n $name\_best 2>>$error >> $log\n\n";
628+
print OUT $bestTree;
629+
if ( system($bestTree) ) { die "Error running $bestTree.\n"; }
630+
631+
return "Bootstrap complete";
632+
close OUT;
633+
}
619634
}
620635

621636
if ( $tree == 3 || $tree == 4 ) {
622637
print OUT "Reconstructing phylogeny using IQ-tree after finding the best model\n";
623-
if ($bootstrap > 0){
638+
if ($bsignal == 1){
624639
print OUT "Also bootstraping IQ-Trees trees\n";
625640
print OUT "\n";
626641
my $iqtree
@@ -667,11 +682,11 @@ sub bootstrap {
667682
open( OUT, ">>$log" );
668683
if ( $tree == 2 || $tree == 4 ) {
669684
my $bootTrees
670-
= "raxmlHPC-PTHREADS -p 10 -T $thread -m GTRGAMMAI -b 10000 -t $outdir/RAxML_bestTree.$name -s $outdir/$name\_snp_alignment.fna -w $outdir -N $bootstrap -n $name\_b -k 2>>$error >> $log\n\n";
685+
= "raxmlHPC-PTHREADS -p 10 -T $thread -m GTRGAMMAI -b 10000 -t $outdir/RAxML_bestTree.$name -s $outdir/$name\_all_alignment.fna -w $outdir -N $bootstrap -n $name\_b -k 2>>$error >> $log\n\n";
671686
print OUT $bootTrees;
672687
if ( system($bootTrees) ) { die "Error running $bootTrees.\n"; }
673688
my $bestTree
674-
= "raxmlHPC-PTHREADS -p 10 -T $thread -f b -m GTRGAMMAI -t $outdir/RAxML_bestTree.$name -s $outdir/$name\_snp_alignment.fna -z $outdir/RAxML_bootstrap.$name\_b -w $outdir -n $name\_best 2>>$error >> $log\n\n";
689+
= "raxmlHPC-PTHREADS -p 10 -T $thread -f b -m GTRGAMMAI -t $outdir/RAxML_bestTree.$name -s $outdir/$name\_all_alignment.fna -z $outdir/RAxML_bootstrap.$name\_b -w $outdir -n $name\_best 2>>$error >> $log\n\n";
675690
print OUT $bestTree;
676691
if ( system($bestTree) ) { die "Error running $bestTree.\n"; }
677692

@@ -739,14 +754,15 @@ sub translateGenes {
739754
my $bindir = shift;
740755
my $thread = shift;
741756
my $program = shift;
757+
my $gencode = shift;
742758
my $error = shift;
743759
my $log = shift;
744760
my $genedir = $dir . '/PSgenes';
745761

746762
open( OUT, ">>$log" );
747763
print OUT "\n";
748764
my $translate
749-
= "parallel_run.pl -d $genedir -t $thread -m $program 2>>$error >> $log\n\n";
765+
= "parallel_run.pl -d $genedir -t $thread -m $program -g $gencode 2>>$error >> $log\n\n";
750766
print OUT $translate;
751767
if ( system($translate) ) { die "Error running $translate.\n"; }
752768
close OUT;
@@ -758,14 +774,15 @@ sub alignGenes {
758774
my $bindir = shift;
759775
my $thread = shift;
760776
my $program = shift;
777+
my $gencode = shift;
761778
my $error = shift;
762779
my $log = shift;
763780
my $genedir = $dir . '/PSgenes';
764781

765782
open( OUT, ">>$log" );
766783
print OUT "\n";
767784
my $align
768-
= "parallel_run.pl -d $genedir -t $thread -m $program 2>>$error >> $log\n\n";
785+
= "parallel_run.pl -d $genedir -t $thread -m $program -g $gencode 2>>$error >> $log\n\n";
769786
print OUT $align;
770787
if ( system($align) ) { die "Error running $align.\n"; }
771788
close OUT;
@@ -777,14 +794,15 @@ sub revTransGenes {
777794
my $bindir = shift;
778795
my $thread = shift;
779796
my $program = shift;
797+
my $gencode = shift;
780798
my $error = shift;
781799
my $log = shift;
782800
my $genedir = $dir . '/PSgenes';
783801

784802
open( OUT, ">>$log" );
785803
print OUT "\n";
786804
my $revTrans
787-
= "parallel_run.pl -d $genedir -t $thread -m $program 2>>$error >> $log\n\n";
805+
= "parallel_run.pl -d $genedir -t $thread -m $program -g $gencode 2>>$error >> $log\n\n";
788806
print OUT $revTrans;
789807
if ( system($revTrans) ) { die "Error running $revTrans.\n"; }
790808
close OUT;

src/parallel_run.pl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
'd=s' => \$dir,
2121
't=i' => \$thread,
2222
'm=s' => \$program,
23+
'g=i' => \$gencode,
2324
'h|help' => sub {usage()},
2425
);
2526

@@ -74,7 +75,7 @@ sub usage
7475
my ($ref_file_name,$ref_file_path,$ref_file_suffix)=fileparse("$files[$i]", qr/\.[^.]*/);
7576
if ($program=~/oneline/){`fasta_oneline.pl $files[$i] > $ref_file_path/$ref_file_name.faa`}
7677
if ($program=~ /mafft/i){`unset MAFFT_BINARIES; mafft --quiet --auto $mafft_options $files[$i] > $ref_file_path/$ref_file_name.msa`;}
77-
if ($program=~/pal2nal/){`pal2nal.pl $files[$i] $ref_file_path/$ref_file_name.fna -output fasta > $ref_file_path/$ref_file_name.cdn`;}
78+
if ($program=~/pal2nal/){`pal2nal.pl $files[$i] $ref_file_path/$ref_file_name.fna -codontable $gencode -output fasta > $ref_file_path/$ref_file_name.cdn`;}
7879
# if ($program=~/pal2nal/){`pal2nal.pl $files[$i] $ref_file_path/$ref_file_name.fna -output fasta > $ref_file_path/$ref_file_name.cdn`;}
7980
if ($program=~ /translate/){
8081
print "Translating $files[$i] to $ref_file_path/$ref_file_name.faa\n";

0 commit comments

Comments
 (0)