Support standard MOOS pattern - run() reads server/port from mission file

Co-authored-by: msis <577139+msis@users.noreply.github.com>

Author: Copilot

Documentation/examples/simpleapp.moos

@@ -1,5 +1,5 @@
 // Example mission file for simpleapp.py
-// To run: python simpleapp.py --mission_file=simpleapp.moos
+// Standard MOOS pattern: python simpleapp.py (modify code to call app.run('simpleapp.moos'))
 
 ServerHost = localhost
 ServerPort = 9000

Documentation/examples/simpleapp.py

@@ -65,10 +65,11 @@ def main():
     app.set_on_new_mail_callback(on_new_mail)
     app.set_iterate_callback(iterate)
 
-    # Run the application (this blocks until iterate returns False)
-    # You can optionally provide a mission file path for configuration:
-    # app.run('localhost', 9000, 'pymoos_simple_app', 'simpleapp.moos')
-    # Or run without a mission file (using defaults in on_startup):
+    # Standard MOOS pattern: Run with mission file
+    # The mission file contains ServerHost, ServerPort, and Community
+    # app.run('simpleapp.moos')
+    
+    # Alternative: Run without mission file (provide server, port, name manually)
     app.run('localhost', 9000, 'pymoos_simple_app')
 
 if __name__ == "__main__":

README.md

@@ -73,11 +73,15 @@ app.set_on_start_up_callback(on_startup)
 app.set_on_connect_to_server_callback(on_connect_to_server)
 app.set_iterate_callback(iterate)
 
-# Optionally provide a mission file for configuration
-app.run('localhost', 9000, 'my_app', 'my_mission.moos')
+# Standard MOOS pattern: Run with mission file
+# ServerHost, ServerPort, and Community are read from the mission file
+app.run('my_mission.moos')
+
+# Alternative: Run without mission file (provide connection details manually)
+# app.run('localhost', 9000, 'my_app')
 ```
 
-The `app` class automatically handles `AppTick` and `CommsTick` from the mission file. 
+The `app` class automatically reads `ServerHost`, `ServerPort`, `AppTick`, and `CommsTick` from the mission file. 
 For custom configuration parameters, use:
 - `get_configuration_string(param)` - Read string parameters
 - `get_configuration_double(param)` - Read numeric parameters

src/pyMOOS.cpp

@@ -229,12 +229,24 @@ class AppWrapper : public CMOOSApp {
         // Clean shutdown
     }
 
-    bool Run(const std::string & sServer, int Port, const std::string & sMyName, const std::string & sMissionFile = "") {
+    // Standard MOOS pattern: Run with mission file (reads server/port/name from file)
+    bool Run(const std::string & sMissionFile) {
+        SetMissionFile(sMissionFile);
+        return BASE::Run();
+    }
+
+    // Alternative: Run with explicit parameters (for when mission file is not used)
+    bool Run(const std::string & sServer, int Port, const std::string & sMyName) {
         SetAppName(sMyName);
         SetServer(sServer, Port);
-        if (!sMissionFile.empty()) {
-            SetMissionFile(sMissionFile);
-        }
+        return BASE::Run();
+    }
+
+    // Run with explicit parameters and mission file
+    bool Run(const std::string & sServer, int Port, const std::string & sMyName, const std::string & sMissionFile) {
+        SetAppName(sMyName);
+        SetServer(sServer, Port);
+        SetMissionFile(sMissionFile);
         return BASE::Run();
     }
 
@@ -747,10 +759,19 @@ PYBIND11_MODULE(pymoos, m) {
     py::class_<MOOS::AppWrapper, CMOOSApp>(m, "app")
         .def(py::init<>())
 
-        .def("run", &MOOS::AppWrapper::Run,
-                    "Run the MOOS application.",
-                    py::arg("server"), py::arg("port"), py::arg("name"), 
-                    py::arg("mission_file") = "")
+        .def("run", static_cast<bool(MOOS::AppWrapper::*)(const std::string&)>(&MOOS::AppWrapper::Run),
+                    "Run the MOOS application with mission file. "
+                    "Server, port, and app name are read from the mission file.",
+                    py::arg("mission_file"))
+        
+        .def("run", static_cast<bool(MOOS::AppWrapper::*)(const std::string&, int, const std::string&)>(&MOOS::AppWrapper::Run),
+                    "Run the MOOS application with explicit server, port, and name. "
+                    "Use this when not using a mission file.",
+                    py::arg("server"), py::arg("port"), py::arg("name"))
+        
+        .def("run", static_cast<bool(MOOS::AppWrapper::*)(const std::string&, int, const std::string&, const std::string&)>(&MOOS::AppWrapper::Run),
+                    "Run the MOOS application with both explicit parameters and mission file.",
+                    py::arg("server"), py::arg("port"), py::arg("name"), py::arg("mission_file"))
 
         .def("fetch", &MOOS::AppWrapper::FetchMailAsVector,
                     "Fetch incoming mail as a vector.")