Save cohort updates and exit immediately (#1805)

* Save cohort updates and exit immediately

Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>

* Remove screenshot requirement from PR template

Removed the requirement for screenshots in the pull request checks.

---------

Signed-off-by: Angelica Ochoa <15623749+ao508@users.noreply.github.com>

Author: ao508

.github/PULL_REQUEST_TEMPLATE.md

@@ -36,7 +36,6 @@ Please follow these checks if any changes were made to any classes in the web, s
 
 **Code checks:**
 - [ ] Endpoints were tested to ensure their integrity.
-- [ ] Screenshots have been provided to demonstrate changes made to the response body JSON schema and/or swagger page.
 - [ ] Unit tests were updated in relation to updates to the mocked test data.
 
 If no unit tests were updated or added, then please explain why: [insert details here]

service/src/main/java/org/mskcc/smile/service/impl/CohortCompleteServiceImpl.java

@@ -46,8 +46,10 @@ public class CohortCompleteServiceImpl implements CohortCompleteService {
     public void saveCohort(Cohort cohort, Set<String> sampleIds) throws Exception {
         // persist new cohort complete event to the db
         cohortCompleteRepository.save(cohort);
-        if (sampleIds == null) {
-            LOG.error("No samples saved for cohort: " + cohort.getCohortId());
+        if (sampleIds == null || sampleIds.isEmpty()) {
+            LOG.error("No samples saved for cohort: " + cohort.getCohortId()
+                    + " - persisting cohort to SMILE and exiting.");
+            return;
         }
 
         Map<String, Object> result