bcachefs: Fix warning in bch2_fs_journal_stop()

Kent Overstreet · Kent Overstreet · commit 7f2de6947f92 · 2024-08-22T02:07:23.000-04:00
j-&gt;last_empty_seq needs to match j-&gt;seq when the journal is empty

Reported-by: syzbot+4093905737cf289b6b38@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/journal.c b/fs/bcachefs/journal.c
@@ -1260,7 +1260,7 @@ int bch2_fs_journal_start(struct journal *j, u64 cur_seq)
 	}
 
 	if (!had_entries)
-		j->last_empty_seq = cur_seq;
+		j->last_empty_seq = cur_seq - 1; /* to match j->seq */
 
 	spin_lock(&j->lock);
 

Original file line number	Diff line number	Diff line change
`@@ -1260,7 +1260,7 @@ int bch2_fs_journal_start(struct journal *j, u64 cur_seq)`
`1260`	`1260`	`}`
`1261`	`1261`
`1262`	`1262`	`if (!had_entries)`
`1263`		`- j->last_empty_seq = cur_seq;`
	`1263`	`+ j->last_empty_seq = cur_seq - 1; /* to match j->seq */`
`1264`	`1264`
`1265`	`1265`	`spin_lock(&j->lock);`
`1266`	`1266`