bcachefs: Fix double assignment in check_dirent_to_subvol()

Yuesong Li · Kent Overstreet · commit dedb2fe37574 · 2024-08-22T02:40:52.000-04:00
ret was assigned twice in check_dirent_to_subvol(). Reported by cocci.

Signed-off-by: Yuesong Li &lt;liyuesong@vivo.com&gt;
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/fsck.c b/fs/bcachefs/fsck.c
@@ -2006,7 +2006,6 @@ static int check_dirent_to_subvol(struct btree_trans *trans, struct btree_iter *
 	if (ret) {
 		bch_err(c, "subvol %u points to missing inode root %llu", target_subvol, target_inum);
 		ret = -BCH_ERR_fsck_repair_unimplemented;
-		ret = 0;
 		goto err;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -2006,7 +2006,6 @@ static int check_dirent_to_subvol(struct btree_trans trans, struct btree_iter `
`2006`	`2006`	`if (ret) {`
`2007`	`2007`	`bch_err(c, "subvol %u points to missing inode root %llu", target_subvol, target_inum);`
`2008`	`2008`	`ret = -BCH_ERR_fsck_repair_unimplemented;`
`2009`		`- ret = 0;`
`2010`	`2009`	`goto err;`
`2011`	`2010`	`}`
`2012`	`2011`