Skip to content

Commit ee59be3

Browse files
t-8chgregkh
authored andcommitted
misc/pvpanic-pci: register attributes via pci_driver
In __pci_register_driver(), the pci core overwrites the dev_groups field of the embedded struct device_driver with the dev_groups from the outer struct pci_driver unconditionally. Set dev_groups in the pci_driver to make sure it is used. This was broken since the introduction of pvpanic-pci. Fixes: db3a4f0 ("misc/pvpanic: add PCI driver") Cc: [email protected] Signed-off-by: Thomas Weißschuh <[email protected]> Fixes: ded13b9 ("PCI: Add support for dev_groups to struct pci_driver") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 4108a30 commit ee59be3

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/misc/pvpanic/pvpanic-pci.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ static struct pci_driver pvpanic_pci_driver = {
4444
.name = "pvpanic-pci",
4545
.id_table = pvpanic_pci_id_tbl,
4646
.probe = pvpanic_pci_probe,
47-
.driver = {
48-
.dev_groups = pvpanic_dev_groups,
49-
},
47+
.dev_groups = pvpanic_dev_groups,
5048
};
5149
module_pci_driver(pvpanic_pci_driver);

0 commit comments

Comments
 (0)