nfc support

[rhjdvsgsgks]

i saw on pmos wiki. there are some device have nfc support. but none of them are msm8974. is that due to some hardware limitation?

[minlexx]

No

[rhjdvsgsgks]

after some search. i found that bacon is using pn544. which already used on other mainline device (such as dumpling). so, seems like i only need to write a dt for it.
this is my first time about mainlining something. maybe it will lot of month and mostly will failed. if someone also interested in it. please ignore my progress and work. and do what you want

some reference i found:
https://github.com/LineageOS/android_kernel_oppo_msm8974/blob/lineage-18.1/arch/arm/boot/dts/msm8974-oppo/msm8974-oppo-nfc.dtsi
https://github.com/LineageOS/android_kernel_oneplus_msm8998/blob/lineage-20/arch/arm/boot/dts/qcom/dumpling.dtsi
https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi

[rhjdvsgsgks]

ok. i get it able to list by nfctool -l. still working on make it able to enable

[z3ntu]

And please share your changes when you have something working!

[rhjdvsgsgks]

finally. i get it works. what blocked me so long is that the pin for nfc defined in device tree is actually not used. the real pin is hard coded in the diver.

https://github.com/LineageOS/android_kernel_oneplus_msm8974/blob/675fd24b98e3a98695725dd17fb0216e7bd1895e/arch/arm/boot/dts/msm8974-oppo/msm8974-oppo-nfc.dtsi#L35-L37
https://github.com/LineageOS/android_kernel_oneplus_msm8974/blob/84bb8fee677f3d6b606e7c21efd34571cc4c818d/drivers/nfc/pn544-oppo_find7op.c#L49-L51

which branch should my pr based on? the wip one?

[z3ntu]

6.10-wip is good yes. Otherwise 6.9.y is also okay

[z3ntu]

PR is open, but Signed-off-by is missing from the author unfortunately. #17