Skip to content

Commit 5dd9fc5

Browse files
msrathore-dbclaude
andcommitted
Remove PR-specific comments from code
Clean up comments that reference implementation details rather than describing what the code does. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent ac917b8 commit 5dd9fc5

File tree

4 files changed

+1
-5
lines changed

4 files changed

+1
-5
lines changed

csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,6 @@ public override IArrowArrayStream GetObjects(GetObjectsDepth depth, string? cata
653653
(bool?)null;
654654

655655
// Get precision/scale from Thrift using SetPrecisionScaleAndTypeName
656-
// This preserves the original Thrift behavior of using server-provided values
657656
var tempTableInfo = new TableInfo(string.Empty);
658657
SetPrecisionScaleAndTypeName(colType, typeName, tempTableInfo, columnSize, decimalDigits);
659658

csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -625,8 +625,6 @@ protected internal QueryResult EnhanceGetColumnsResult(Schema originalSchema, IR
625625
);
626626

627627
// Extract values with fallback to Thrift-provided values
628-
// This preserves the existing behavior where parsed values take precedence,
629-
// but Thrift values are used if parsing fails or returns null
630628
string baseTypeName = record.BaseTypeName ?? typeName ?? string.Empty;
631629
int finalColumnSize = record.XdbcColumnSize ?? columnSize;
632630
int finalDecimalDigits = record.XdbcDecimalDigits ?? decimalDigits;

csharp/src/Drivers/Apache/Hive2/Metadata/MetadataFieldPopulator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ public virtual ForeignKeyMetadataRecord PopulateForeignKeyMetadata(
254254

255255
/// <summary>
256256
/// Virtual extension point for populating vendor-specific custom fields on column metadata.
257-
/// Override in derived classes to add Delta Lake, Iceberg, or other vendor-specific fields.
257+
/// Override in derived classes to add additional metadata fields beyond the standard JDBC/ODBC columns.
258258
/// </summary>
259259
/// <param name="record">The column metadata record to populate</param>
260260
/// <param name="customData">Custom data from the vendor-specific protocol</param>

csharp/src/Drivers/Apache/Spark/SparkConnection.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ internal override void SetPrecisionScaleAndTypeName(
115115
default:
116116
{
117117
// For all other types (INTEGER, BIGINT, FLOAT, etc.), use null for precision/scale
118-
// This preserves the original Thrift behavior
119118
tableInfo?.Precision.Add(null);
120119
tableInfo?.Scale.Add(null);
121120
tableInfo?.BaseTypeName.Add(baseTypeName);

0 commit comments

Comments
 (0)