Skip to content

Commit 6321f5c

Browse files
committed
Remove debugid_util.rs
Replace with samply-symbols
1 parent 4783f15 commit 6321f5c

File tree

5 files changed

+4
-119
lines changed

5 files changed

+4
-119
lines changed

samply-symbols/src/binary_image.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ use object::read::pe::{ImageNtHeaders, ImageOptionalHeader, PeFile, PeFile32, Pe
55
use object::{FileKind, Object, ReadRef};
66
use samply_debugid::{CodeId, ElfBuildId, PeCodeId};
77

8-
use crate::debugid_util::{code_id_for_object, debug_id_for_object};
98
use crate::error::Error;
109
use crate::jitdump::{debug_id_and_code_id_for_jitdump, JitDumpIndex};
1110
use crate::macho::{DyldCacheFileData, MachOData, MachOFatArchiveMemberData};
1211
use crate::shared::{
1312
relative_address_base, FileAndPathHelperError, FileContents, FileContentsWrapper, LibraryInfo,
1413
RangeReadRef,
1514
};
15+
use samply_debugid::{code_id_for_object, debug_id_for_object};
1616

1717
#[derive(thiserror::Error, Debug)]
1818
pub enum CodeByteReadingError {

samply-symbols/src/debugid_util.rs

Lines changed: 0 additions & 114 deletions
This file was deleted.

samply-symbols/src/lib.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ mod breakpad;
220220
mod cache;
221221
mod chunked_read_buffer_manager;
222222
mod compact_symbol_table;
223-
mod debugid_util;
224223
mod demangle;
225224
mod demangle_ocaml;
226225
mod dwarf;
@@ -245,7 +244,6 @@ pub use crate::breakpad::{
245244
};
246245
pub use crate::cache::{FileByteSource, FileContentsWithChunkedCaching};
247246
pub use crate::compact_symbol_table::CompactSymbolTable;
248-
pub use crate::debugid_util::{debug_id_for_object, DebugIdExt};
249247
pub use crate::demangle::demangle_any;
250248
pub use crate::error::Error;
251249
pub use crate::external_file::{load_external_file, ExternalFileSymbolMap};
@@ -263,6 +261,7 @@ pub use crate::shared::{
263261
};
264262
pub use crate::source_file_path::{SourceFilePath, SourceFilePathHandle, SourceFilePathIndex};
265263
pub use crate::symbol_map::{AccessPatternHint, SymbolMap, SymbolMapTrait};
264+
pub use samply_debugid::{debug_id_for_object, DebugIdExt};
266265

267266
pub struct SymbolManager<H: FileAndPathHelper> {
268267
helper: Arc<H>,

samply-symbols/src/macho.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ use yoke::Yoke;
1414
use yoke_derive::Yokeable;
1515

1616
use crate::binary_image::{BinaryImage, BinaryImageInner};
17-
use crate::debugid_util::debug_id_for_object;
1817
use crate::dwarf::Addr2lineContextData;
1918
use crate::error::Error;
2019
use crate::shared::{
@@ -25,6 +24,7 @@ use crate::symbol_map::SymbolMap;
2524
use crate::symbol_map_object::{
2625
ObjectSymbolMap, ObjectSymbolMapInnerWrapper, ObjectSymbolMapOuter,
2726
};
27+
use samply_debugid::debug_id_for_object;
2828

2929
/// Converts a cpu type/subtype pair into the architecture name.
3030
///

samply-symbols/src/windows.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ use pdb_addr2line::pdb;
1010
use yoke::Yoke;
1111
use yoke_derive::Yokeable;
1212

13-
use crate::debugid_util::debug_id_for_object;
1413
use crate::dwarf::Addr2lineContextData;
1514
use crate::error::{Context, Error};
1615
use crate::generation::SymbolMapGeneration;
@@ -24,6 +23,7 @@ use crate::symbol_map_object::{
2423
ObjectSymbolMap, ObjectSymbolMapInnerWrapper, ObjectSymbolMapOuter,
2524
};
2625
use crate::{demangle, PathInterner, SourceFilePath, SourceFilePathHandle, SyncAddressInfo};
26+
use samply_debugid::debug_id_for_object;
2727

2828
pub async fn load_symbol_map_for_pdb_corresponding_to_binary<H: FileAndPathHelper>(
2929
file_kind: FileKind,

0 commit comments

Comments
 (0)