Fix clippy. (#660)

Author: mstange

gecko_profile/src/lib.rs

@@ -110,7 +110,7 @@ impl ProfileBuilder {
         marker_schemas
     }
 
-    pub fn to_serializable(&self) -> SerializableProfile {
+    pub fn to_serializable(&self) -> SerializableProfile<'_> {
         SerializableProfile(self)
     }
 }

samply-api/src/symbolicate/request_json.rs

@@ -8,7 +8,7 @@ pub enum Request {
 }
 
 impl Request {
-    pub fn jobs(&self) -> JobIterator {
+    pub fn jobs(&self) -> JobIterator<'_> {
         match self {
             Request::WithJobsList { jobs } => JobIterator::WithJobsList(jobs.iter()),
             Request::JustOneJob(job) => JobIterator::JustOneJob(std::iter::once(job)),

samply-symbols/src/macho.rs

@@ -492,7 +492,7 @@ impl<T: FileContents> MachOFatArchiveMemberData<T> {
         }
     }
 
-    pub fn data(&self) -> RangeReadRef<&'_ FileContentsWrapper<T>> {
+    pub fn data(&self) -> RangeReadRef<'_, &'_ FileContentsWrapper<T>> {
         let file_contents_ref = &self.file_data;
         file_contents_ref.range(self.start_offset, self.range_size)
     }
@@ -629,7 +629,7 @@ impl<'data, R: ReadRef<'data>> MachOData<'data, R> {
 
     fn load_command_iter<M: MachHeader>(
         &self,
-    ) -> object::read::Result<(M::Endian, LoadCommandIterator<M::Endian>)> {
+    ) -> object::read::Result<(M::Endian, LoadCommandIterator<'_, M::Endian>)> {
         let header = M::parse(self.data, self.header_offset)?;
         let endian = header.endian()?;
         let load_commands = header.load_commands(endian, self.data, self.header_offset)?;

samply-symbols/src/windows.rs

@@ -113,7 +113,7 @@ impl<T: FileContents + 'static> PeSymbolMapDataAndObject<T> {
 }
 
 impl<T: FileContents + 'static> ObjectSymbolMapOuter<T> for PeSymbolMapDataAndObject<T> {
-    fn make_symbol_map_inner(&self) -> Result<ObjectSymbolMapInnerWrapper<T>, Error> {
+    fn make_symbol_map_inner(&self) -> Result<ObjectSymbolMapInnerWrapper<'_, T>, Error> {
         let PeObject {
             file_data,
             object,
@@ -205,7 +205,7 @@ trait PdbAddr2lineContextTrait {
     fn find_frames(
         &self,
         probe: u32,
-    ) -> Result<Option<pdb_addr2line::FunctionFrames>, pdb_addr2line::Error>;
+    ) -> Result<Option<pdb_addr2line::FunctionFrames<'_>>, pdb_addr2line::Error>;
     fn function_count(&self) -> usize;
     fn functions(&self) -> Box<dyn Iterator<Item = pdb_addr2line::Function> + '_>;
 }
@@ -214,7 +214,7 @@ impl PdbAddr2lineContextTrait for pdb_addr2line::Context<'_, '_> {
     fn find_frames(
         &self,
         probe: u32,
-    ) -> Result<Option<pdb_addr2line::FunctionFrames>, pdb_addr2line::Error> {
+    ) -> Result<Option<pdb_addr2line::FunctionFrames<'_>>, pdb_addr2line::Error> {
         self.find_frames(probe)
     }
 

samply/src/linux/perf_event.rs

@@ -459,7 +459,7 @@ impl Perf {
     }
 
     #[inline]
-    pub fn iter(&mut self) -> EventIter {
+    pub fn iter(&mut self) -> EventIter<'_> {
         EventIter::new(self)
     }
 }

samply/src/mac/thread_info.rs

@@ -56,21 +56,6 @@ pub struct thread_extended_info {
     pub pth_name: [::std::os::raw::c_char; 64usize],
 }
 pub type thread_extended_info_data_t = thread_extended_info;
-#[repr(C)]
-#[derive(Debug, Default)]
-pub struct io_stat_entry {
-    pub count: u64,
-    pub size: u64,
-}
-#[repr(C)]
-#[derive(Debug, Default)]
-pub struct io_stat_info {
-    pub disk_reads: io_stat_entry,
-    pub io_priority: [io_stat_entry; 4usize],
-    pub paging: io_stat_entry,
-    pub metadata: io_stat_entry,
-    pub total_io: io_stat_entry,
-}
 
 pub const THREAD_BASIC_INFO_COUNT: mach_msg_type_number_t =
     (size_of::<thread_basic_info_data_t>() / size_of::<natural_t>()) as _;

samply/src/shared/process_sample_data.rs

@@ -219,6 +219,7 @@ impl StaticSchemaMarker for OtherEventMarker {
 }
 
 #[derive(Debug, Clone)]
+#[allow(dead_code)]
 pub struct UserTimingMarker(pub StringHandle);
 
 impl StaticSchemaMarker for UserTimingMarker {

samply/src/windows/xperf.rs

@@ -143,9 +143,8 @@ impl Xperf {
 
         eprintln!("xperf session running...");
 
-        if user_etl_file.is_some() {
-            self.state =
-                XperfState::RecordingKernelAndUserToFile(kernel_etl_file, user_etl_file.unwrap());
+        if let Some(user_etl) = user_etl_file {
+            self.state = XperfState::RecordingKernelAndUserToFile(kernel_etl_file, user_etl);
         } else {
             self.state = XperfState::RecordingKernelToFile(kernel_etl_file);
         }