thread 'tokio-runtime-worker' panicked at db2-0.9.2\src\modi\mod.rs:200:9 when Symbolicating

[jsjtxietian]

When running cargo run -- record XX\Product.exe I encountered several panick:

thread 'tokio-runtime-worker' panicked at XX.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb2-0.9.2\src\modi\mod.rs:200:9:
assertion failed: self.offset <= end_offset

stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\std\src\panicking.rs:697
   1: core::panicking::panic_fmt
             at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\core\src\panicking.rs:75
   2: core::panicking::panic
             at /rustc/29483883eed69d5fb4db01964cdf2af4d86e9cb2/library\core\src\panicking.rs:145
   3: pdb2::modi::LineInfo::set_end
             at XX\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb2-0.9.2\src\modi\mod.rs:200
   4: pdb2::modi::c13::impl$38::next
             at XX\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb2-0.9.2\src\modi\c13.rs:1041
   5: pdb2::modi::impl$6::next
             at XX\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb2-0.9.2\src\modi\mod.rs:294
   6: pdb_addr2line::impl$6::get_lines::closure$0
             at XX\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb-addr2line-0.11.2\src\lib.rs:1136
   7: enum2$<core::option::Option<enum2$<core::result::Result<alloc::vec::Vec<pdb_addr2line::CachedLineInfo,alloc::alloc::Global>,enum2$<pdb_addr2line::error::Error> > > > >::get_or_insert_with<enum2$<core::result::Result<alloc::vec::Vec<pdb_addr2line::CachedLin
             at XX\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\option.rs:1753
   8: pdb_addr2line::FunctionLineInfo::get_lines
             at XX\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb-addr2line-0.11.2\src\lib.rs:1133
   9: pdb_addr2line::Context::find_frames
             at XX\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\pdb-addr2line-0.11.2\src\lib.rs:562
  10: samply_symbols::windows::impl$5::find_frames
             at .\samply-symbols\src\windows.rs:218
  11: samply_symbols::windows::impl$6::lookup_sync
             at .\samply-symbols\src\windows.rs:273
  12: samply_symbols::windows::impl$10::lookup_sync::closure$0<enum2$<wholesym::helper::WholesymFileContents> >
             at .\samply-symbols\src\windows.rs:407
  13: samply_symbols::windows::PdbSymbolMap<enum2$<wholesym::helper::WholesymFileContents> >::with_inner<enum2$<wholesym::helper::WholesymFileContents>,samply_symbols::windows::impl$10::lookup_sync::closure_env$0<enum2$<wholesym::helper::WholesymFileContents> >,
             at .\samply-symbols\src\windows.rs:376
  14: samply_symbols::windows::impl$10::lookup_sync<enum2$<wholesym::helper::WholesymFileContents> >
             at .\samply-symbols\src\windows.rs:407
  15: samply_symbols::symbol_map::SymbolMap<wholesym::helper::Helper>::lookup_sync<wholesym::helper::Helper>
             at .\samply-symbols\src\symbol_map.rs:121
  16: samply_api::symbolicate::impl$0::symbolicate_requested_addresses_for_lib::async_fn$0<wholesym::helper::Helper>
             at .\samply-api\src\symbolicate\mod.rs:97
  17: samply_api::symbolicate::impl$0::symbolicate_requested_addresses::async_fn$0<wholesym::helper::Helper>
             at .\samply-api\src\symbolicate\mod.rs:62
  18: samply_api::symbolicate::impl$0::query_api::async_fn$0<wholesym::helper::Helper>
             at .\samply-api\src\symbolicate\mod.rs:50
  19: samply_api::symbolicate::impl$0::query_api_fallible_json::async_fn$0<wholesym::helper::Helper>
             at .\samply-api\src\symbolicate\mod.rs:39
  20: samply_api::symbolicate::impl$0::query_api_json::async_fn$0<wholesym::helper::Helper>
             at .\samply-api\src\symbolicate\mod.rs:31
  21: samply_api::impl$0::query_api::async_fn$0<wholesym::helper::Helper>
             at .\samply-api\src\lib.rs:200
  22: wholesym::symbol_manager::impl$2::query_json_api::async_fn$0
             at .\wholesym\src\symbol_manager.rs:291
  23: samply::server::symbolication_service::async_fn$0
             at .\samply\src\server.rs:353

If I try with --presymbolicate it won't panick but Symbolicating failed silently. It could be related to certain pdb files that the crate https://github.com/afranchuk/pdb may fail to read.

[ducklin5]

1. Install the master version of samply (it has the presymbolicate flag)
   cargo install --git https://github.com/mstange/samply.git samply
2. record your application with the presymbolicate flag, and also specify where the product.pdb will be (target/debug)
   samply.exe record --presymbolicate --symbol-dir=target\debug\ target\debug\product.exe

did you include the --symbol-dir flag?

[jsjtxietian]

It can find the pdb, so if I include --presymbolicate it still panics :
thread 'main' panicked at samply\src\shared\presymbolicate.rs:122:31: called Result::unwrap()on anErr value: JoinError::Panic(Id(55), "assertion failed: self.offset <= end_offset", ...)