jim.c: Only a return code of -1 (JIM_USAGE) produces usage error

msteveb · msteveb · commit 5575c554c2e6 · 2025-08-28T17:50:10.000+10:00
Previously any negative value would produce a usage message but this can affect some code that uses negative return codes for its own purpose. Fixes: #356 Signed-off-by: Steve Bennett <steveb@workware.net.au>
diff --git a/jim.c b/jim.c
@@ -11922,7 +11922,7 @@ static int JimCallNative(Jim_Interp *interp, Jim_Cmd *cmd, int argc, Jim_Obj *co
     if (argsok) {
         interp->cmdPrivData = cmd->u.native.privData;
         ret = cmd->u.native.cmdProc(interp, argc, argv);
-        if (ret >= 0) {
+        if (ret != JIM_USAGE) {
             return ret;
         }
         /* This means an argument error */

Original file line number	Diff line number	Diff line change
`@@ -11922,7 +11922,7 @@ static int JimCallNative(Jim_Interp interp, Jim_Cmd cmd, int argc, Jim_Obj *co`
`11922`	`11922`	`if (argsok) {`
`11923`	`11923`	`interp->cmdPrivData = cmd->u.native.privData;`
`11924`	`11924`	`ret = cmd->u.native.cmdProc(interp, argc, argv);`
`11925`		`- if (ret >= 0) {`
	`11925`	`+ if (ret != JIM_USAGE) {`
`11926`	`11926`	`return ret;`
`11927`	`11927`	`}`
`11928`	`11928`	`/* This means an argument error */`