Skip to content

Commit fd00b2e

Browse files
committed
Revert to using non-memoized computations for building widgets
1 parent 1155bb8 commit fd00b2e

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

lib/src/computed_flutter.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ class _Token {}
66

77
mixin _ComputedFlutterElementMixin on ComponentElement {
88
final _forceRebuild = ValueNotifier(_Token());
9-
var _buildToken = _Token(); // Hack to keep Computed from undoing the DAG
109
var _dirty = false;
1110
var _ignoreListener = true;
12-
ComputedSubscription<_Token>? _sub;
11+
ComputedSubscription<void>? _sub;
1312
Widget? _result;
1413
Object? _error;
1514
StackTrace? _trace;
@@ -32,9 +31,8 @@ mixin _ComputedFlutterElementMixin on ComponentElement {
3231
_error = e;
3332
_trace = s;
3433
}
35-
return _buildToken;
36-
}).listen((_) {
37-
_buildToken = _Token();
34+
}, memoized: false)
35+
.listen((_) {
3836
if (!_ignoreListener) super.markNeedsBuild();
3937
_ignoreListener = false;
4038
}, null);

pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ dependencies:
1111
flutter:
1212
sdk: flutter
1313
built_collection: ^5.1.1
14-
computed: ^0.3.0
15-
#computed:
16-
# path: ../computed
14+
#computed: ^0.3.0
15+
computed:
16+
path: ../computed
1717
dev_dependencies:
1818
flutter_test:
1919
sdk: flutter

0 commit comments

Comments
 (0)