Skip to content

Commit 7a86e4c

Browse files
committed
Define _LIBCPP_ABI_UNSTABLE manually when building libcxxabi
This is set via a cmake option when building libcxx, but libcxxabi uses the raw libcxx headers from its include directory before they are installed. This fixes cases of inconsistent classes seen while compiling libcxxabi and libcxx. With potential future patches to clang to adjust how classes are exported with dllexport, this change is needed to avoid conflicts.
1 parent 4d861b6 commit 7a86e4c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build-libcxx.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ build_all() {
167167
-DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=OFF \
168168
-DLLVM_NO_OLD_LIBSTDCXX=TRUE \
169169
-DCXX_SUPPORTS_CXX11=TRUE \
170-
-DCMAKE_CXX_FLAGS="$LIBCXXABI_VISIBILITY_FLAGS -D_LIBCPP_HAS_THREAD_API_WIN32 -w" \
170+
-DCMAKE_CXX_FLAGS="$LIBCXXABI_VISIBILITY_FLAGS -D_LIBCPP_HAS_THREAD_API_WIN32 -D_LIBCPP_ABI_UNSTABLE -w" \
171171
..
172172
make -j$CORES
173173
cd ..

0 commit comments

Comments
 (0)