Skip to content

Commit 85c0ef1

Browse files
committed
test: Don't build asan/ubsan tests with PDB debug info
The DWARF debug info should work just as well. Since 8c03f400a837dc9333e54ab371e7904aa2bec43c in llvm-project, llvm-symbolizer prefers DWARF over PDB if there is a DWARF section in the inspected executable. Thus, in order to use PDB, one would have to strip out any remnants of DWARF debug info from the executable, like in run-lldb-tests.sh (e.g. by -Wl,-s). For the purposes of this test, simplifying the setup to use DWARF works just as well.
1 parent 9c48a7d commit 85c0ef1

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

test/Makefile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,6 @@ EXTRAFILES = \
143143
$(addprefix lib, $(addsuffix .dll.a, $(TESTS_CPP_DLL))) \
144144
$(addsuffix .h, $(TESTS_IDL)) \
145145
$(addsuffix -rc.o, $(TESTS_RES)) \
146-
$(addsuffix -asan.pdb, $(TESTS_ASAN)) \
147-
$(addsuffix -asan-cfguard.pdb, $(TESTS_ASAN_CFGUARD))
148146

149147
all: $(TARGETS)
150148

@@ -187,14 +185,14 @@ $(TARGETS_FORTIFY): %-fortify$(EXEEXT): %.c
187185
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -O2 -D_FORTIFY_SOURCE=2
188186

189187
$(TARGETS_ASAN): %-asan$(EXEEXT): %.c
190-
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -fsanitize=address -g -gcodeview -Wl,--pdb=
188+
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -fsanitize=address -g
191189

192190
$(TARGETS_UBSAN): %$(EXEEXT): %.c
193191
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -fsanitize=undefined -fno-sanitize-recover=all
194192

195193
# Smoke test ASAN with CFGuard to make sure it doesn't trip.
196194
$(TARGETS_ASAN_CFGUARD): %-asan-cfguard$(EXEEXT): %.c
197-
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -fsanitize=address -g -gcodeview -mguard=cf -Wl,--pdb=
195+
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -fsanitize=address -g -mguard=cf
198196

199197
$(TARGETS_OMP): %$(EXEEXT): %.c
200198
$(CC) $(CPPFLAGS) $(CFLAGS) $< -o $@ -fopenmp=libomp

0 commit comments

Comments
 (0)