Skip to content

Commit e633b48

Browse files
committed
test: Add a comment about a test that fails when run emulated on arm
The test is specific to building for x86, for a msvcrt.dll target, and running that binary on arm.
1 parent 4c82a47 commit e633b48

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

test/crt-test.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,13 @@ void test_parse_numbers() {
749749

750750
TEST_STRTOD_64B_RANGE(strtod, );
751751
#ifndef MSVCRT_DLL_NOANSI
752+
// This test fails on msvcrt.dll when not using -D__USE_MINGW_ANSI_STDIO=1
753+
// (which sets __USE_MINGW_STRTOX), hence the ifdef.
754+
//
755+
// When using the mingw provided wcstod on x86, this test succeeds (and
756+
// thus is included). But when running such a binary emulated on ARM, this
757+
// particular test fails, as the range checks in __mingw_wcstod rely on
758+
// 80 bit long doubles really having more precision than 64 bit doubles.
752759
TEST_STRTOD_64B_RANGE(wcstod, L);
753760
#endif
754761

0 commit comments

Comments
 (0)