Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Commit 843ef23

Browse files
committed
Touch up the comments in the 'tag-contains' branch
Thomas Braun pointed out several documentation shortcomings. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 0712284 commit 843ef23

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

builtin/tag.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,11 @@ static int contains_test(struct commit *candidate,
9999
}
100100

101101
/*
102-
* This stack on the heap mimics the real stack in the previous implementation
103-
* of contains_recurse() that had to be replaced because it easily led to a
104-
* stack overflow.
102+
* Mimicking the real stack, this stack lives on the heap, avoiding stack
103+
* overflows.
105104
*
106-
* Every stack item points at a certain commit whose parents are iterated over.
107-
* Each item's current parent is the current next stack item's commit.
105+
* At each recursion step, the stack items points to the commits whose
106+
* ancestors are to be inspected.
108107
*/
109108
struct stack {
110109
int nr, alloc;

t/t7004-tag.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,9 +1380,8 @@ test_expect_success 'multiple --points-at are OR-ed together' '
13801380
test_cmp expect actual
13811381
'
13821382
1383-
# what about a deep repo ?
1384-
13851383
>expect
1384+
# ulimit is a bash builtin; we can rely on that in MinGW, but nowhere else
13861385
test_expect_success MINGW '--contains works in a deep repo' '
13871386
ulimit -s 64
13881387
i=1 &&

0 commit comments

Comments
 (0)