Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Commit bb07a3f

Browse files
committed
Merge branch 'jn/less-reconfigure'
A change made on v1.8.1.x maintenance track had a nasty regression to break the build when autoconf is used. * jn/less-reconfigure: Makefile: avoid infinite loop on configure.ac change
2 parents ef94636 + 7f1b697 commit bb07a3f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

Makefile

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1821,12 +1821,14 @@ $(patsubst %.py,%,$(SCRIPT_PYTHON)): % : unimplemented.sh
18211821
mv $@+ $@
18221822
endif # NO_PYTHON
18231823

1824+
CONFIGURE_RECIPE = $(RM) configure configure.ac+ && \
1825+
sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
1826+
configure.ac >configure.ac+ && \
1827+
autoconf -o configure configure.ac+ && \
1828+
$(RM) configure.ac+
1829+
18241830
configure: configure.ac GIT-VERSION-FILE
1825-
$(QUIET_GEN)$(RM) $@ $<+ && \
1826-
sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \
1827-
$< > $<+ && \
1828-
autoconf -o $@ $<+ && \
1829-
$(RM) $<+
1831+
$(QUIET_GEN)$(CONFIGURE_RECIPE)
18301832

18311833
ifdef AUTOCONFIGURED
18321834
# We avoid depending on 'configure' here, because it gets rebuilt
@@ -1835,7 +1837,7 @@ ifdef AUTOCONFIGURED
18351837
# do want to recheck when the platform/environment detection logic
18361838
# changes, hence this depends on configure.ac.
18371839
config.status: configure.ac
1838-
$(QUIET_GEN)$(MAKE) configure && \
1840+
$(QUIET_GEN)$(CONFIGURE_RECIPE) && \
18391841
if test -f config.status; then \
18401842
./config.status --recheck; \
18411843
else \

0 commit comments

Comments
 (0)