Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Commit e1d6b55

Browse files
devzero2000gitster
authored andcommitted
t4006-diff-mode.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent a4cf6b4 commit e1d6b55

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t4006-diff-mode.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ sed_script='s/\(:100644 100755\) \('"$_x40"'\) \2 /\1 X X /'
1313
test_expect_success 'setup' '
1414
echo frotz >rezrov &&
1515
git update-index --add rezrov &&
16-
tree=`git write-tree` &&
16+
tree=$(git write-tree) &&
1717
echo $tree
1818
'
1919

0 commit comments

Comments
 (0)