|
| 1 | +# NOTICE.txt updates |
| 2 | + |
| 3 | +## question |
| 4 | +Are there any recommendations to update the NOTICE.txt file in the root of the packages? |
| 5 | + |
| 6 | +We have recently received a GH issue [NOTICE calls out gpl-3.0 for non-gpl-3.0 packages · Issue #43717 · Azure/azure-sdk-for-python](https://github.com/Azure/azure-sdk-for-python/issues/43717) requesting to update the NOTICE.txt in azure-ai-ml package. |
| 7 | + |
| 8 | +We found the general recommendations here [NOTICE generation | Docs - Microsoft Open Source](https://docs.opensource.microsoft.com/tools/cg/legal/notice/). Could someone please help us figure out what is the right approach to update the NOTICE.txt? |
| 9 | + |
| 10 | +## answer |
| 11 | +Attaching the links shared by Justin: |
| 12 | +1. [Attribution guidelines | Docs - Microsoft Open Source](https://docs.opensource.microsoft.com/legal/cela-guidance/attribution-guidelines/) |
| 13 | +2. [NOTICE FAQ | Docs - Microsoft Open Source](https://docs.opensource.microsoft.com/using/guidance-for-open-source-usage/notice-faq/#q-when-do-i-need-a-notice) |
| 14 | +3. [NOTICE FAQ | Docs - Microsoft Open Source](https://docs.opensource.microsoft.com/using/guidance-for-open-source-usage/notice-faq/#q-does-cela-need-to-review-the-notice) |
| 15 | + |
| 16 | +So it seems we would need a notice if: |
| 17 | +- compiled build or any other scenario where the recipient can no longer access or view the code in source code form (attribute the full dependency tree that is distributed). |
| 18 | + Since it's Python, we only deliver source files in Python. This SDK does not even include native code in C/C++. |
| 19 | +- source code repository (attribute open source copied into the repo; not referenced dependencies). |
| 20 | + This SDK doesn't copy/paste OSS code from 3P offering. |
| 21 | + |
| 22 | +The SDK package we put on PyPI doesn't contain any source file that is copied from any other OSS components. So my understanding is that we don't need a NOTICE. |
| 23 | + |
| 24 | +# Python emitter issue with bulleted list TypeSpec doc string, and other |
| 25 | + |
| 26 | +## question |
| 27 | +This TypeSpec repo/branch/folder: https://github.com/Azure/azure-rest-api-specs-pr/tree/feature/ai-foundry/agents-v2/specification/ai/Azure.AI.Projects |
| 28 | + |
| 29 | +Is emitted into this Python repo/branch/folder: https://github.com/Azure/azure-sdk-for-python/tree/feature/azure-ai-projects/2.0.0b1/sdk/ai/azure-ai-projects |
| 30 | + |
| 31 | +Using the command `tsp-client update --debug --local-spec-repo <path>` |
| 32 | + |
| 33 | +I have a green build, other than errors in the "Build Docs" stage, as seen in this build of the branc: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5527867&view=results |
| 34 | + |
| 35 | +I need some guidance on how to update TypeSpec to make these Python doc generation go away. |
| 36 | + |
| 37 | +The errors are the following: |
| 38 | + |
| 39 | +``` |
| 40 | +updating environment: [new config] 7 added, 0 changed, 0 removed |
| 41 | +docstring of azure.ai.projects.models.Reasoning.generate_summary:6: WARNING: Inline strong start-string without end-string. [docutils] |
| 42 | +docstring of azure.ai.projects.models.WorkflowDefinition.workflow:2: WARNING: Duplicate explicit target name: "learn more". [docutils] |
| 43 | +docstring of azure.ai.projects.models.WorkflowDefinition.workflow:2: WARNING: Duplicate explicit target name: "learn more". [docutils] |
| 44 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:54: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 45 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:61: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 46 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:64: ERROR: Unexpected indentation. [docutils] |
| 47 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:65: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 48 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:67: ERROR: Unexpected indentation. [docutils] |
| 49 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:79: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 50 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:82: ERROR: Unexpected indentation. [docutils] |
| 51 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:83: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 52 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:89: ERROR: Unexpected indentation. [docutils] |
| 53 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:90: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 54 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:109: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] |
| 55 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._models.Response:112: ERROR: Unexpected indentation. [docutils] |
| 56 | +docstring of azure.ai.projects.models.WorkflowDefinition.workflow:2: WARNING: Duplicate explicit target name: "learn more". [docutils] |
| 57 | +docstring of azure.ai.projects.models.Response.output:10: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 58 | +docstring of azure.ai.projects.models.Response.output:12: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils] |
| 59 | +docstring of azure.ai.projects.models.Response.tools:9: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 60 | +docstring of azure.ai.projects.models.Response.tools:12: ERROR: Unexpected indentation. [docutils] |
| 61 | +docstring of azure.ai.projects.models.Response.tools:13: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 62 | +docstring of azure.ai.projects.models.Response.truncation:8: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 63 | +docstring of azure.ai.projects.models.Response.truncation:11: ERROR: Unexpected indentation. [docutils] |
| 64 | +docstring of azure.ai.projects.models.Response.truncation:12: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] |
| 65 | +docstring of azure.ai.projects.models.WorkflowDefinition.workflow:2: WARNING: Duplicate explicit target name: "learn more". [docutils] |
| 66 | +E:\src\sdk-repos\azure-sdk-for-python\sdk\ai\azure-ai-projects\.tox\sphinx\Lib\site-packages\azure\ai\projects\models\__init__.py:docstring of azure.ai.projects.models._enums.ServiceTier:4: WARNING: Bullet list ends without a blank line; unexpected unindent. [docutils] |
| 67 | +``` |
| 68 | + |
| 69 | +It comes from two TypeSpec models, direct link here: |
| 70 | +Response model - https://github.com/Azure/azure-rest-api-specs-pr/blob/feature/ai-foundry/agents-v2/specification/ai/Azure.AI.Projects/.external-readonly/openai.external.typespec/responses/custom.tsp#L38 |
| 71 | +ServiceTier union - https://github.com/Azure/azure-rest-api-specs-pr/blob/feature/ai-foundry/agents-v2/specification/ai/Azure.AI.Projects/.external-readonly/openai.external.typespec/responses/custom.tsp#L38 |
| 72 | + |
| 73 | +## answer |
| 74 | +Within the pyproject.toml for the problematic package, disable the sphinx environment is my advice. that way you won't hit these sphinx failures. |
| 75 | + |
| 76 | +``` |
| 77 | +[tool.azure-sdk-build] |
| 78 | +sphinx = false |
| 79 | +``` |
0 commit comments