switch from all_of to for-loop in ThreadEntrySet::basicSanity()

Summary: In non-optimized ASAN-instrumented builds, the `all_of` has a measurable cost.

Reviewed By: dmm-fb

Differential Revision: D76755340

fbshipit-source-id: 0326dfa603853e055074feea9d51f5a5cf7d1f17

Author: yfeldblum

third-party/folly/src/folly/detail/ThreadLocalDetail.cpp

@@ -73,15 +73,13 @@ bool ThreadEntrySet::basicSanity() const {
   if (!(dist(rng) < constexpr_log2(size))) {
     return true;
   }
-  return //
-      threadElements.size() == entryToVectorSlot.size() &&
-      std::all_of(
-          entryToVectorSlot.begin(),
-          entryToVectorSlot.end(),
-          [&](auto const& kvp) {
-            return kvp.second < threadElements.size() &&
-                threadElements[kvp.second].threadEntry == kvp.first;
-          });
+  for (auto const& kvp : entryToVectorSlot) {
+    if (!(kvp.second < threadElements.size() &&
+          threadElements[kvp.second].threadEntry == kvp.first)) {
+      return false;
+    }
+  }
+  return true;
 }
 
 void ThreadEntrySet::clear() {