remove unnecessary compiler hint to unbreak GenAI on aarch64

Summary: We've run into a super curious issue where the folly JSON encoder appeared to be producing corrupted integers when built with gcc for aarch64. We believe removing these compiler hints works around that issue while we attempt to fix gcc with no perf impact because the branch predictor should do the right thing even without these hints.

Reviewed By: anobra, Gownta

Differential Revision: D76633143

fbshipit-source-id: cd0bca04552ffb916ee21dec3beac2c12aa86f55

Author: sdunster

third-party/folly/src/folly/lang/ToAscii.h

@@ -276,7 +276,7 @@ FOLLY_ALWAYS_INLINE void to_ascii_with_table(
     char* out, size_t size, uint64_t v) {
   using table = to_ascii_table<Base, Alphabet>;
   auto pos = size;
-  while (FOLLY_UNLIKELY(pos > 2)) {
+  while (pos > 2) {
     pos -= 2;
     //  keep /, % together so a peephole optimization computes them together
     auto const q = v / (Base * Base);
@@ -287,7 +287,7 @@ FOLLY_ALWAYS_INLINE void to_ascii_with_table(
   }
 
   auto const val = table::data.data[size_t(v)];
-  if (FOLLY_UNLIKELY(pos == 2)) {
+  if (pos == 2) {
     std::memcpy(out, &val, 2);
   } else {
     *out = val >> (kIsLittleEndian ? 8 : 0);