Skip to content

Commit 92cca74

Browse files
vassilmladenovfacebook-github-bot
authored andcommitted
Fix test
Summary: This test was added by {D76565975}; I do not know why it landed if there was a test failure. V2 runs: https://www.internalfb.com/intern/testinfra/diagnostics/14355223901855648.562950174871117.1749791364/ aarch64 - https://www.internalfb.com/intern/testinfra/diagnostics/7036874690889025.281475198122330.1749789197/ The actual difference appears to be the order of the elements in the array Native Facts gives us: ``` Notice: Implicit string to Class conversion for classname E in %s/class-ptr/facts/facts.php on line 10 E Notice: Implicit string to Class conversion for classname D in %s/class-ptr/facts/facts.php on line 10 D ``` vs. ``` Notice: Implicit string to Class conversion for classname D in /data/users/vmladenov/hhvm/fbcode/hphp/test/slow/class-ptr/facts/facts.php on line 10 D Notice: Implicit string to Class conversion for classname E in /data/users/vmladenov/hhvm/fbcode/hphp/test/slow/class-ptr/facts/facts.php on line 10 E ``` filed T227568155 to investigate Reviewed By: chessvivek Differential Revision: D76630211 fbshipit-source-id: 01aedc140f2715eac5d86555d3b881928120f05b
1 parent 4e4f95d commit 92cca74

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

hphp/test/slow/class-ptr/facts/facts.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
class C { public function __construct() { echo nameof static."\n"; }}
44
class D extends C {}
5-
class E extends C {}
5+
// class E extends C {} // TODO(T227568155)
66
class F extends D {}
77

88
function v($a): void {

hphp/test/slow/class-ptr/facts/facts.php.expectf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,12 @@
22

33
Notice: Implicit Class to string conversion for argument 1 passed to HH\Facts\subtypes() in %s/class-ptr/facts/facts.php on line 17
44

5-
Notice: Implicit string to Class conversion for classname E in %s/class-ptr/facts/facts.php on line 10
6-
E
7-
85
Notice: Implicit string to Class conversion for classname D in %s/class-ptr/facts/facts.php on line 10
96
D
107
===== transitive_subtypes =====
118

129
Notice: Implicit Class to string conversion for argument 1 passed to HH\Facts\transitive_subtypes() in %s/class-ptr/facts/facts.php on line 21
1310

14-
Notice: Implicit string to Class conversion for classname E in %s/class-ptr/facts/facts.php on line 10
15-
E
16-
1711
Notice: Implicit string to Class conversion for classname D in %s/class-ptr/facts/facts.php on line 10
1812
D
1913

0 commit comments

Comments
 (0)